Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flytepropeller] Add Tests in v1alpha.go including array_test.go, branch_test.go, error_test.go, and iface_test.go with 0.13% Coverage Improvment #4234

Conversation

Future-Outlier
Copy link
Member

@Future-Outlier Future-Outlier commented Oct 15, 2023

TL;DR

Please take a look at the line I change the package from v1alpha1_test to v1alpha1.
I really think it is unnecessary to use a new package, thanks a lot!

https://github.com/flyteorg/flyte/pull/4234/files#diff-e0b8581c1dadc5bdd862a6388d98c81d652943ef1f46c7eeb18d14f6665b7fabR1

Tracking issue

Fixes #4209

Describe your changes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Screenshots

before
image
after
image

Signed-off-by: Future Outlier <[email protected]>
@Future-Outlier Future-Outlier changed the title [flytepropeller] Add Tests in v1alpha.go array_test.go, branch_test.go, error_test.go, and iface_test.go [flytepropeller] Add Tests in v1alpha.go inclugin array_test.go, branch_test.go, error_test.go, and iface_test.go Oct 15, 2023
@Future-Outlier Future-Outlier changed the title [flytepropeller] Add Tests in v1alpha.go inclugin array_test.go, branch_test.go, error_test.go, and iface_test.go [flytepropeller] Add Tests in v1alpha.go including array_test.go, branch_test.go, error_test.go, and iface_test.go Oct 15, 2023
@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0fc2ab0) 59.59% compared to head (a14ebd3) 60.23%.

❗ Current head a14ebd3 differs from pull request most recent head ae67c87. Consider uploading reports for the commit ae67c87 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4234      +/-   ##
==========================================
+ Coverage   59.59%   60.23%   +0.64%     
==========================================
  Files         632      562      -70     
  Lines       53628    40297   -13331     
==========================================
- Hits        31960    24274    -7686     
+ Misses      19147    13669    -5478     
+ Partials     2521     2354     -167     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 571 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Future-Outlier Future-Outlier changed the title [flytepropeller] Add Tests in v1alpha.go including array_test.go, branch_test.go, error_test.go, and iface_test.go [flytepropeller] Add Tests in v1alpha.go including array_test.go, branch_test.go, error_test.go, and iface_test.go with 0.13% Coverage Improvment Oct 18, 2023
Future Outlier added 4 commits October 18, 2023 15:10
… flytepropeller-pkg-apis-flyteworkflow-test

Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
@Future-Outlier
Copy link
Member Author

@pingsutw I think it is able to be approved and merged, please take a look, thanks a lot

@pingsutw pingsutw enabled auto-merge (squash) November 11, 2023 07:35
@pingsutw pingsutw merged commit 033276d into flyteorg:master Nov 11, 2023
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Housekeeping] Improve Test Coverage
3 participants