Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ios_platform_images] Add extension tests #4925

Merged
merged 3 commits into from
Sep 14, 2023
Merged

[ios_platform_images] Add extension tests #4925

merged 3 commits into from
Sep 14, 2023

Conversation

stuartmorgan
Copy link
Contributor

Adds test coverage of the UIImage class extension that allows native code to load Flutter assets by name.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@stuartmorgan
[ios_platform_images] Add extension tests
6533b45 
Adds test coverage of the UIImage class extension that allows native
code to load Flutter assets by name.
@stuartmorgan stuartmorgan added the override: no changelog needed Override the check requiring CHANGELOG updates for most changes label Sep 14, 2023
@stuartmorgan
Copy link
Contributor Author

No changelog: the build changes are only to support unit tests.

@stuartmorgan stuartmorgan mentioned this pull request Sep 14, 2023
Merged
11 tasks
tarrinneal
tarrinneal approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@tarrinneal tarrinneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGBWAQ

packages/ios_platform_images/example/ios/RunnerTests/UIImage+ios_platform_imagesTests.m Outdated Show resolved Hide resolved
@stuartmorgan stuartmorgan added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Sep 14, 2023
@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 14, 2023
hellohuanlin
hellohuanlin approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@hellohuanlin hellohuanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this test!

packages/ios_platform_images/example/ios/RunnerTests/UIImage+ios_platform_imagesTests.m
@import XCTest;

// The tests test the UIImage extension which is a public API intended for use from native code
// outside of the plugin (see package README). Any change that requires changing existing tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow im surprised that this is a public API.

@auto-submit auto-submit bot merged commit aa46622 into flutter:main Sep 14, 2023
@stuartmorgan stuartmorgan deleted the ios-platform-images-extension-unit-tests branch September 14, 2023 23:44
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 15, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 15, 2023
@engine-flutter-autoroll
aa46622 [ios_platform_images] Add extension tests (flutter/packages#4925
d066b94 
)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Sep 15, 2023
@engine-flutter-autoroll
Roll Packages from 275b76c to bc8c2f2 (7 revisions) (#134823)
0b9551e 
flutter/packages@275b76c...bc8c2f2

2023-09-15 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.6 to 2.21.7 (flutter/packages#4930)
2023-09-14 [email protected] [ios_platform_images] Add extension tests (flutter/packages#4925)
2023-09-14 [email protected] Roll Flutter (stable) from 2524052 to 367f9ea (3 revisions) (flutter/packages#4929)
2023-09-14 [email protected] [ci] Enable ios_platform_images tests (flutter/packages#4920)
2023-09-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.5 to 2.21.6 (flutter/packages#4922)
2023-09-14 [email protected] Roll Flutter from 61b890b to 58ba6c2 (16 revisions) (flutter/packages#4928)
2023-09-14 [email protected] Manual Roll of Flutter from 4e7a07a to 61b890b   (flutter/packages#4919)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Sep 15, 2023
Merged
11 tasks
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@engine-flutter-autoroll @Mairramer
Roll Packages from 275b76c to bc8c2f2 (7 revisions) (flutter#134823)
fc2b261 
flutter/packages@275b76c...bc8c2f2

2023-09-15 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.6 to 2.21.7 (flutter/packages#4930)
2023-09-14 [email protected] [ios_platform_images] Add extension tests (flutter/packages#4925)
2023-09-14 [email protected] Roll Flutter (stable) from 2524052 to 367f9ea (3 revisions) (flutter/packages#4929)
2023-09-14 [email protected] [ci] Enable ios_platform_images tests (flutter/packages#4920)
2023-09-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.5 to 2.21.6 (flutter/packages#4922)
2023-09-14 [email protected] Roll Flutter from 61b890b to 58ba6c2 (16 revisions) (flutter/packages#4928)
2023-09-14 [email protected] Manual Roll of Flutter from 4e7a07a to 61b890b   (flutter/packages#4919)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarrinneal tarrinneal tarrinneal approved these changes

@hellohuanlin hellohuanlin hellohuanlin approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes p: ios_platform_images platform-ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stuartmorgan @hellohuanlin @tarrinneal