Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual Roll of Flutter from 4e7a07af882c to 61b890bfcbc1 #4919

Merged
merged 34 commits into from
Sep 14, 2023

Conversation

camsim99
Copy link
Contributor

@camsim99 camsim99 commented Sep 13, 2023

Manual Flutter -> packages roll; taking over #4918 to fix OOM error by increasing JVM memory of legacy all_projects app (example error: https://ci.chromium.org/ui/p/flutter/builders/try/Linux_android%20android_build_all_packages%20master/2323/overview).

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

camsim99 added 30 commits May 1, 2023 16:46
@camsim99 camsim99 requested review from stuartmorgan and a team September 13, 2023 21:51
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge when you're happy with the memory increase! (Thanks for checking with smaller values!)

@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 14, 2023
@auto-submit auto-submit bot merged commit 050ad15 into flutter:main Sep 14, 2023
70 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 15, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Sep 15, 2023
flutter/packages@275b76c...bc8c2f2

2023-09-15 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.6 to 2.21.7 (flutter/packages#4930)
2023-09-14 [email protected] [ios_platform_images] Add extension tests (flutter/packages#4925)
2023-09-14 [email protected] Roll Flutter (stable) from 2524052 to 367f9ea (3 revisions) (flutter/packages#4929)
2023-09-14 [email protected] [ci] Enable ios_platform_images tests (flutter/packages#4920)
2023-09-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.5 to 2.21.6 (flutter/packages#4922)
2023-09-14 [email protected] Roll Flutter from 61b890b to 58ba6c2 (16 revisions) (flutter/packages#4928)
2023-09-14 [email protected] Manual Roll of Flutter from 4e7a07a to 61b890b   (flutter/packages#4919)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Sep 15, 2023
11 tasks
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
flutter/packages@275b76c...bc8c2f2

2023-09-15 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.6 to 2.21.7 (flutter/packages#4930)
2023-09-14 [email protected] [ios_platform_images] Add extension tests (flutter/packages#4925)
2023-09-14 [email protected] Roll Flutter (stable) from 2524052 to 367f9ea (3 revisions) (flutter/packages#4929)
2023-09-14 [email protected] [ci] Enable ios_platform_images tests (flutter/packages#4920)
2023-09-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.5 to 2.21.6 (flutter/packages#4922)
2023-09-14 [email protected] Roll Flutter from 61b890b to 58ba6c2 (16 revisions) (flutter/packages#4928)
2023-09-14 [email protected] Manual Roll of Flutter from 4e7a07a to 61b890b   (flutter/packages#4919)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants