[tools,pigeon] Update tooling to handle Windows build output changes #4826
Conversation
stuartmorgan
changed the title
|
This is now ready for review. I tested it with a roll to make sure it would work (which is how I found the Pigeon part, which I'd forgotten would be an issue), but since it also needs to support the |
| const String buildDirBase = '$examplePath/build/windows'; | ||
| const String buildRelativeBinaryPath = | ||
| 'plugins/test_plugin/Debug/test_plugin_test.exe'; | ||
| final String arch = Abi.current() == Abi.windowsArm64 ? 'arm64' : 'x64'; |
There was a problem hiding this comment.
Currently, the tool creates x64 executables on Windows Arm64 machines (the executable runs using emulation). Creating Windows Arm64 executables on Arm64 hosts by default is tracked by flutter/flutter#129807.
In other words, in the long-term this script is correct, but in the short-term (until flutter/flutter#129807 lands) this script should use build/windows/x64 on Windows Arm64 hosts. Feel free to keep this as-is if you don't plan to run this script on Windows Arm64 hosts until after flutter/flutter#129807 lands.
There was a problem hiding this comment.
Thanks, I misremembered what the roadmap ordering was on the arm64 support.
To avoid having a mini fire-drill when flutter/flutter#129807 lands, I've made the scripts messier for now but future-proof, so that they will work with the new structure with only x64, but then use the new structure with arm64 when it starts working.
Are there greater implications to pigeon than just the testing? Or is pigeon too high level for it to matter? |
|
All that changes is where build products go; Pigeon is only affected because it has hand-rolled test scripts, so is sensitive to changes in where the test binaries end up. |
stuartmorgan
added
the
autosubmit
I didn't think it was worth tracking bugs; they shouldn't affect anything, so it'll just be opportunistic cleanup when someone is editing that code after enough time has passed. I just wanted the comment there to make it clear when it could be simplified. |
flutter/packages@e7d812c...22d4754 2023-09-07 [email protected] Roll Flutter (stable) from ff5b5b5 to 2524052 (6 revisions) (flutter/packages#4866) 2023-09-07 [email protected] [webview_flutter_platform_interface] Adds option to override console log (flutter/packages#4701) 2023-09-01 [email protected] [tools,pigeon] Update tooling to handle Windows build output changes (flutter/packages#4826) 2023-08-31 [email protected] [google_maps_flutter] Cloud-based map styling support (flutter/packages#3682) 2023-08-31 [email protected] [ci] Convert version presubmit check to LUCI (flutter/packages#4822) 2023-08-31 [email protected] [url_launcher_android] Add support for Custom Tabs (flutter/packages#4739) 2023-08-31 [email protected] [webview_flutter] update pigeon to 11 (flutter/packages#4821) 2023-08-31 [email protected] Roll Flutter (stable) from e1e4722 to ff5b5b5 (1 revision) (flutter/packages#4823) 2023-08-31 [email protected] Roll Flutter from 1fe2495 to c175cf8 (30 revisions) (flutter/packages#4825) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Updates the tooling that builds and runs Windows unit tests to handle the build output path changes in flutter/flutter#131843