-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tools,pigeon] Update tooling to handle Windows build output changes #4826
Merged
auto-submit
merged 7 commits into
flutter:main
from
stuartmorgan:windows-build-output-changes
Sep 1, 2023
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6ef4c26
Add Windows arm64 support to native unit tests
stuartmorgan 2c0be09
Add a roll for validation
stuartmorgan c538b0e
Analysis fix
stuartmorgan c967291
Fix Pigeon test tooling
stuartmorgan e724eaf
Analyzer fix
stuartmorgan d769cda
Undo roll
stuartmorgan acafb9d
Add x64 fallback on arm64 hosts
stuartmorgan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, the tool creates x64 executables on Windows Arm64 machines (the executable runs using emulation). Creating Windows Arm64 executables on Arm64 hosts by default is tracked by flutter/flutter#129807.
In other words, in the long-term this script is correct, but in the short-term (until flutter/flutter#129807 lands) this script should use
build/windows/x64
on Windows Arm64 hosts. Feel free to keep this as-is if you don't plan to run this script on Windows Arm64 hosts until after flutter/flutter#129807 lands.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I misremembered what the roadmap ordering was on the arm64 support.
To avoid having a mini fire-drill when flutter/flutter#129807 lands, I've made the scripts messier for now but future-proof, so that they will work with the new structure with only x64, but then use the new structure with arm64 when it starts working.