Add CPE translation mapping for IntelliJ CE for Windows #25971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Won't solve the false positive issues due to version number mismatches, but will fix the false negative where CE wasn't matching at all. For #25662.
|
@jmwatts another QA-on-branch PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #25971 +/- ##
==========================================
- Coverage 63.61% 63.61% -0.01%
==========================================
Files 1623 1624 +1
Lines 155440 155702 +262
Branches 4008 4008
==========================================
+ Hits 98883 99047 +164
- Misses 48756 48838 +82
- Partials 7801 7817 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ksykulev
approved these changes
Feb 5, 2025
|
Assigned for on-branch QA since this affects the vuln feed after merge to |
iansltx
added a commit
that referenced
this pull request
Feb 5, 2025
Won't solve the false positive issues due to version number mismatches, but will fix the false negative where CE wasn't matching at all, and this is a full fix for IJ CE installed via JetBrains Toolbox. For #25662. # Checklist for submitter If some of the following don't apply, delete the relevant line. <!-- Note that API documentation changes are now addressed by the product design team. --> - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [x] Added/updated automated tests - [x] A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it) - [x] Manual QA for all new/changed functionality
iansltx
added a commit
that referenced
this pull request
Feb 5, 2025
Won't solve the false positive issues due to version number mismatches, but will fix the false negative where CE wasn't matching at all, and this is a full fix for IJ CE installed via JetBrains Toolbox. For #25662. # Checklist for submitter If some of the following don't apply, delete the relevant line. <!-- Note that API documentation changes are now addressed by the product design team. --> - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [x] Added/updated automated tests - [x] A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it) - [x] Manual QA for all new/changed functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Won't solve the false positive issues due to version number mismatches, but will fix the false negative where CE wasn't matching at all, and this is a full fix for IJ CE installed via JetBrains Toolbox.
For #25662.
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.