Skip to content

Commit

Permalink
Add CPE translation mapping for IntelliJ CE for Windows (#25971)
Browse files Browse the repository at this point in the history
Won't solve the false positive issues due to version number mismatches,
but will fix the false negative where CE wasn't matching at all, and
this is a full fix for IJ CE installed via JetBrains Toolbox.

For #25662.

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [x] Added/updated automated tests
- [x] A detailed QA plan exists on the associated ticket (if it isn't
there, work with the product group's QA engineer to add it)
- [x] Manual QA for all new/changed functionality
  • Loading branch information
iansltx committed Feb 5, 2025
1 parent 1907269 commit 52ab8d2
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 0 deletions.
1 change: 1 addition & 0 deletions changes/25662-ij-windows
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* Resolved false negatives on vulnerabilities for IntelliJ IDEA Community Edition on Windows.
9 changes: 9 additions & 0 deletions server/vulnerabilities/nvd/cpe_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1341,6 +1341,15 @@ func TestCPEFromSoftwareIntegration(t *testing.T) {
},
cpe: "cpe:2.3:a:jetbrains:goland:2022.3.99.123.456:*:*:*:*:macos:*:*",
},
{
software: fleet.Software{
Name: "IntelliJ IDEA Community Edition 2022.3.2",
Source: "programs",
Version: "223.8617.56",
Vendor: "",
},
cpe: "cpe:2.3:a:jetbrains:intellij_idea:223.8617.56:*:*:*:*:windows:*:*",
},
{
software: fleet.Software{
Name: "IntelliJ IDEA.app",
Expand Down
10 changes: 10 additions & 0 deletions server/vulnerabilities/nvd/cpe_translations.json
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,16 @@
"vendor": ["jetbrains"]
}
},
{
"software": {
"name": ["/^IntelliJ IDEA Community Edition/"],
"source": ["programs"]
},
"filter": {
"product": ["intellij_idea"],
"vendor": ["jetbrains"]
}
},
{
"software": {
"bundle_identifier": ["/^com\\.jetbrains\\.pycharm/"],
Expand Down

0 comments on commit 52ab8d2

Please sign in to comment.