Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-Pick: Add CPE translation mapping for IntelliJ CE for Windows #26116

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

iansltx
Copy link
Member

@iansltx iansltx commented Feb 5, 2025

Merged into main as #25971. PR to RC to get the changelog in the right place, as this change goes out with the vulns feed update at midnight UTC.

Won't solve the false positive issues due to version number mismatches,
but will fix the false negative where CE wasn't matching at all, and
this is a full fix for IJ CE installed via JetBrains Toolbox.

For #25662.

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [x] Added/updated automated tests
- [x] A detailed QA plan exists on the associated ticket (if it isn't
there, work with the product group's QA engineer to add it)
- [x] Manual QA for all new/changed functionality
@iansltx iansltx requested a review from a team as a code owner February 5, 2025 23:20
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (rc-minor-fleet-v4.64.0@1907269). Learn more about missing BASE report.

Additional details and impacted files
@@                    Coverage Diff                    @@
##             rc-minor-fleet-v4.64.0   #26116   +/-   ##
=========================================================
  Coverage                          ?   63.63%           
=========================================================
  Files                             ?     1631           
  Lines                             ?   156293           
  Branches                          ?     4088           
=========================================================
  Hits                              ?    99455           
  Misses                            ?    48996           
  Partials                          ?     7842           
Flag Coverage Δ
backend 64.47% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iansltx iansltx merged commit e58aec1 into rc-minor-fleet-v4.64.0 Feb 12, 2025
29 of 30 checks passed
@iansltx iansltx deleted the cherry-pick-25662-ij-windows branch February 12, 2025 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants