chore: Prepare towards PHP8.4 compatibility #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolli42
approved these changes
Jul 29, 2024
This was referenced Aug 5, 2024
bshaffer
approved these changes
Aug 7, 2024
4 tasks
|
@bshaffer Can we have this release ASAP (as PHP 8.4 has been released) |
ruudk
added a commit
to ruudk/php-jwt
that referenced
this pull request
Nov 24, 2024
Adds PHP 8.4 to the CI matrix. See firebase#572 and firebase#578
Merged
reviewtypo3org
pushed a commit
to TYPO3/typo3
that referenced
this pull request
Nov 24, 2024
TYPO3 monorepo used a composer patch based on [1]
for the `firebase/php-jwt` package to resolve the
one or other PHP 8.4 issue to allow testing TYPO3
against PHP 8.4. The pull-request has been merged
already months ago and a release has been finally
made [2].
This change removes the composer patch introduced
with #104578 and updates the package version to
ensure having required fixes on board even for
classic mode installations.
Used command(s):
> composer remove --dev "cweagans/composer-patches"
> composer config --no-plugins --no-interaction \
--unset allow-plugins.cweagans/composer-patches
> composer config --no-plugins --no-interaction \
--unset extra.composer-exit-on-patch-failure
> composer config --no-plugins --no-interaction \
--unset extra.patches-file
> composer require -d typo3/sysext/core --no-update \
"firebase/php-jwt":"^6.10.2"
> composer require "firebase/php-jwt":"^6.10.2"
> rm -rf Build/patches
[1] firebase/php-jwt#572
[2] https://github.com/firebase/php-jwt/releases/tag/v6.10.2
Resolves: #105689
Related: #104578
Releases: main, 13.4
Change-Id: I6af68aaacabae9e64f2eecef75a5169943d738d8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/87218
Tested-by: core-ci <[email protected]>
Tested-by: Markus Hofmann <[email protected]>
Reviewed-by: Stefan Bürk <[email protected]>
Tested-by: Garvin Hicking <[email protected]>
Tested-by: Stefan Bürk <[email protected]>
Tested-by: Christian Kuhn <[email protected]>
Reviewed-by: Christian Kuhn <[email protected]>
Reviewed-by: Garvin Hicking <[email protected]>
Reviewed-by: Markus Hofmann <[email protected]>
reviewtypo3org
pushed a commit
to TYPO3/typo3
that referenced
this pull request
Nov 24, 2024
TYPO3 monorepo used a composer patch based on [1]
for the `firebase/php-jwt` package to resolve the
one or other PHP 8.4 issue to allow testing TYPO3
against PHP 8.4. The pull-request has been merged
already months ago and a release has been finally
made [2].
This change removes the composer patch introduced
with #104578 and updates the package version to
ensure having required fixes on board even for
classic mode installations.
Used command(s):
> composer remove --dev "cweagans/composer-patches"
> composer config --no-plugins --no-interaction \
--unset allow-plugins.cweagans/composer-patches
> composer config --no-plugins --no-interaction \
--unset extra.composer-exit-on-patch-failure
> composer config --no-plugins --no-interaction \
--unset extra.patches-file
> composer require -d typo3/sysext/core --no-update \
"firebase/php-jwt":"^6.10.2"
> composer require "firebase/php-jwt":"^6.10.2"
> rm -rf Build/patches
[1] firebase/php-jwt#572
[2] https://github.com/firebase/php-jwt/releases/tag/v6.10.2
Resolves: #105689
Related: #104578
Releases: main, 13.4
Change-Id: I6af68aaacabae9e64f2eecef75a5169943d738d8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/87219
Tested-by: core-ci <[email protected]>
Tested-by: Stefan Bürk <[email protected]>
Reviewed-by: Stefan Bürk <[email protected]>
TYPO3IncTeam
pushed a commit
to TYPO3-CMS/core
that referenced
this pull request
Nov 24, 2024
TYPO3 monorepo used a composer patch based on [1]
for the `firebase/php-jwt` package to resolve the
one or other PHP 8.4 issue to allow testing TYPO3
against PHP 8.4. The pull-request has been merged
already months ago and a release has been finally
made [2].
This change removes the composer patch introduced
with #104578 and updates the package version to
ensure having required fixes on board even for
classic mode installations.
Used command(s):
> composer remove --dev "cweagans/composer-patches"
> composer config --no-plugins --no-interaction \
--unset allow-plugins.cweagans/composer-patches
> composer config --no-plugins --no-interaction \
--unset extra.composer-exit-on-patch-failure
> composer config --no-plugins --no-interaction \
--unset extra.patches-file
> composer require -d typo3/sysext/core --no-update \
"firebase/php-jwt":"^6.10.2"
> composer require "firebase/php-jwt":"^6.10.2"
> rm -rf Build/patches
[1] firebase/php-jwt#572
[2] https://github.com/firebase/php-jwt/releases/tag/v6.10.2
Resolves: #105689
Related: #104578
Releases: main, 13.4
Change-Id: I6af68aaacabae9e64f2eecef75a5169943d738d8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/87218
Tested-by: core-ci <[email protected]>
Tested-by: Markus Hofmann <[email protected]>
Reviewed-by: Stefan Bürk <[email protected]>
Tested-by: Garvin Hicking <[email protected]>
Tested-by: Stefan Bürk <[email protected]>
Tested-by: Christian Kuhn <[email protected]>
Reviewed-by: Christian Kuhn <[email protected]>
Reviewed-by: Garvin Hicking <[email protected]>
Reviewed-by: Markus Hofmann <[email protected]>
TYPO3IncTeam
pushed a commit
to TYPO3-CMS/core
that referenced
this pull request
Nov 24, 2024
TYPO3 monorepo used a composer patch based on [1]
for the `firebase/php-jwt` package to resolve the
one or other PHP 8.4 issue to allow testing TYPO3
against PHP 8.4. The pull-request has been merged
already months ago and a release has been finally
made [2].
This change removes the composer patch introduced
with #104578 and updates the package version to
ensure having required fixes on board even for
classic mode installations.
Used command(s):
> composer remove --dev "cweagans/composer-patches"
> composer config --no-plugins --no-interaction \
--unset allow-plugins.cweagans/composer-patches
> composer config --no-plugins --no-interaction \
--unset extra.composer-exit-on-patch-failure
> composer config --no-plugins --no-interaction \
--unset extra.patches-file
> composer require -d typo3/sysext/core --no-update \
"firebase/php-jwt":"^6.10.2"
> composer require "firebase/php-jwt":"^6.10.2"
> rm -rf Build/patches
[1] firebase/php-jwt#572
[2] https://github.com/firebase/php-jwt/releases/tag/v6.10.2
Resolves: #105689
Related: #104578
Releases: main, 13.4
Change-Id: I6af68aaacabae9e64f2eecef75a5169943d738d8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/87219
Tested-by: core-ci <[email protected]>
Tested-by: Stefan Bürk <[email protected]>
Reviewed-by: Stefan Bürk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request contains three commits:
chore: fix latest php-cs-fixer findings
This ensures clean cgl state using the current php-cs-fixer version and ruleset.
chore: Mitigate PHP8.4 deprecation warnings (#570)
This change replaces implicitly nullable method arguments by making them explicitly nullable to mitigate PHP8.4 deprecation warnings.
chore: Enable php-cs-fixer rules to avoid implicitly nullable method arguments
This change enables two rules in the php-cs-fixer ruleset to guard against future implicitly method arguments and ensures to use the
?nullable operator for nullable methods and properties.BEGIN_COMMIT_OVERRIDE
chore: fix latest php-cs-fixer findings
fix: Mitigate PHP8.4 deprecation warnings (#570)
chore: Enable php-cs-fixer rules to avoid implicitly nullable method arguments
END_COMMIT_OVERRIDE
Resolves: #570