Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds cross-env for OS-agnostic lifecycle hook execution. #686

Merged
merged 1 commit into from
Mar 6, 2018

Conversation

mbleigh
Copy link
Contributor

@mbleigh mbleigh commented Mar 6, 2018

@tinaliang I'd be curious if you can try this out on Windows and see if it works properly.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 57.384% when pulling 970ef9c on mb-cross-env into 071450f on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 57.384% when pulling 970ef9c on mb-cross-env into 071450f on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 57.384% when pulling 970ef9c on mb-cross-env into 071450f on master.

Copy link
Contributor

@tinaliang tinaliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked on Windows machine and the predeploy scripts worked fine!

@tinaliang tinaliang assigned mbleigh and unassigned tinaliang Mar 6, 2018
@mbleigh mbleigh merged commit c9045a4 into master Mar 6, 2018
@mbleigh mbleigh deleted the mb-cross-env branch March 6, 2018 21:19
joehan pushed a commit that referenced this pull request Apr 12, 2021
joehan added a commit that referenced this pull request Apr 13, 2021
* Add publisher to registry file fields (#686)

* Migrate ext:update ref-based flow to include update warnings + min extension version guard (#684)

* Migrate ext:install flow to install via extension reference and remove EAP gating (#679)

* Remove EAP-specific copy in ext:dev:register and ext:dev:publish command (#691)

* Warn user that unpublishing is final in ext:dev:unpublish command (#693)

* Add extMinVersion flag to ext:dev:unpublish command (#698)

* Migrate ext:info flow to retrieve spec from Registry API (#683)

* Migrate "author" terminology to use "publisher" in Extensions CLI commands (#694)

* Fix bug in confirmInstallByReference and refactor ext:install error messages (#702)

* Fix local path detection logic and refactor warnings logic in ext:update flow (#703)

* Migrate extensions warnings relating to audiences to use (backend) launch stage and visibility fields (#705)

* Only infer firebase if publisher not provided as part of user input in ext:info flow (#708)

* Adds new warning prompt for non-trusted publishers during ext:install (#707)

* add new warning prompt for non-trusted publishers during ext:install

* clean up param namne

* clean up comment

* switch from author ulr to sourceUrl

* no please

* Update copy to link user to documentation on ext:install flow if input not found (#711)

* Adds console install link to ext:dev:publish (#709)

* Adds console install link to ext:dev:publish

* formats

* Add firebase ext:dev:delete command to CLI (#712)

* adds changelog

* formats

Co-authored-by: huangjeff5 <[email protected]>
Co-authored-by: Jeff Huang <[email protected]>
Co-authored-by: Elvis Sun <[email protected]>
devpeerapong pushed a commit to devpeerapong/firebase-tools that referenced this pull request Dec 14, 2021
* Add publisher to registry file fields (firebase#686)

* Migrate ext:update ref-based flow to include update warnings + min extension version guard (firebase#684)

* Migrate ext:install flow to install via extension reference and remove EAP gating (firebase#679)

* Remove EAP-specific copy in ext:dev:register and ext:dev:publish command (firebase#691)

* Warn user that unpublishing is final in ext:dev:unpublish command (firebase#693)

* Add extMinVersion flag to ext:dev:unpublish command (firebase#698)

* Migrate ext:info flow to retrieve spec from Registry API (firebase#683)

* Migrate "author" terminology to use "publisher" in Extensions CLI commands (firebase#694)

* Fix bug in confirmInstallByReference and refactor ext:install error messages (firebase#702)

* Fix local path detection logic and refactor warnings logic in ext:update flow (firebase#703)

* Migrate extensions warnings relating to audiences to use (backend) launch stage and visibility fields (firebase#705)

* Only infer firebase if publisher not provided as part of user input in ext:info flow (firebase#708)

* Adds new warning prompt for non-trusted publishers during ext:install (firebase#707)

* add new warning prompt for non-trusted publishers during ext:install

* clean up param namne

* clean up comment

* switch from author ulr to sourceUrl

* no please

* Update copy to link user to documentation on ext:install flow if input not found (firebase#711)

* Adds console install link to ext:dev:publish (firebase#709)

* Adds console install link to ext:dev:publish

* formats

* Add firebase ext:dev:delete command to CLI (firebase#712)

* adds changelog

* formats

Co-authored-by: huangjeff5 <[email protected]>
Co-authored-by: Jeff Huang <[email protected]>
Co-authored-by: Elvis Sun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants