Migrate extensions commands to use registry APIs #3273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tension version guard (#684)
…unch stage and visibility fields (#705)
…n ext:info flow (#708)
…#707) * add new warning prompt for non-trusted publishers during ext:install * clean up param namne * clean up comment * switch from author ulr to sourceUrl
* Adds console install link to ext:dev:publish * formats
|
Can you wait for https://github.com/FirebasePrivate/firebase-tools/pull/712 |
|
@elvisun Of course! |
joehan
force-pushed
the
launch.extensions-registry-migration
branch
2 times, most recently
from
1b61a9b to
a0047af
Compare
huangjeff5
approved these changes
Apr 13, 2021
devpeerapong
pushed a commit
to devpeerapong/firebase-tools
that referenced
this pull request
Dec 14, 2021
* Add publisher to registry file fields (firebase#686) * Migrate ext:update ref-based flow to include update warnings + min extension version guard (firebase#684) * Migrate ext:install flow to install via extension reference and remove EAP gating (firebase#679) * Remove EAP-specific copy in ext:dev:register and ext:dev:publish command (firebase#691) * Warn user that unpublishing is final in ext:dev:unpublish command (firebase#693) * Add extMinVersion flag to ext:dev:unpublish command (firebase#698) * Migrate ext:info flow to retrieve spec from Registry API (firebase#683) * Migrate "author" terminology to use "publisher" in Extensions CLI commands (firebase#694) * Fix bug in confirmInstallByReference and refactor ext:install error messages (firebase#702) * Fix local path detection logic and refactor warnings logic in ext:update flow (firebase#703) * Migrate extensions warnings relating to audiences to use (backend) launch stage and visibility fields (firebase#705) * Only infer firebase if publisher not provided as part of user input in ext:info flow (firebase#708) * Adds new warning prompt for non-trusted publishers during ext:install (firebase#707) * add new warning prompt for non-trusted publishers during ext:install * clean up param namne * clean up comment * switch from author ulr to sourceUrl * no please * Update copy to link user to documentation on ext:install flow if input not found (firebase#711) * Adds console install link to ext:dev:publish (firebase#709) * Adds console install link to ext:dev:publish * formats * Add firebase ext:dev:delete command to CLI (firebase#712) * adds changelog * formats Co-authored-by: huangjeff5 <[email protected]> Co-authored-by: Jeff Huang <[email protected]> Co-authored-by: Elvis Sun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: All code here has been reviewed in separate PRs on FirebasePrivate.