Fix predeploy hooks for directories with spaces in the name #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, the predeploy commands fail with an unhelpful error if you try to run the command from a directory with spaces in the name. Using double quotes guarantees that the variable expands to a single parameter, instead of breaking on spaces.
sphippen
changed the title
1 similar comment
tinaliang
approved these changes
Mar 6, 2018
joehan
added a commit
that referenced
this pull request
Apr 13, 2021
* Add publisher to registry file fields (#686) * Migrate ext:update ref-based flow to include update warnings + min extension version guard (#684) * Migrate ext:install flow to install via extension reference and remove EAP gating (#679) * Remove EAP-specific copy in ext:dev:register and ext:dev:publish command (#691) * Warn user that unpublishing is final in ext:dev:unpublish command (#693) * Add extMinVersion flag to ext:dev:unpublish command (#698) * Migrate ext:info flow to retrieve spec from Registry API (#683) * Migrate "author" terminology to use "publisher" in Extensions CLI commands (#694) * Fix bug in confirmInstallByReference and refactor ext:install error messages (#702) * Fix local path detection logic and refactor warnings logic in ext:update flow (#703) * Migrate extensions warnings relating to audiences to use (backend) launch stage and visibility fields (#705) * Only infer firebase if publisher not provided as part of user input in ext:info flow (#708) * Adds new warning prompt for non-trusted publishers during ext:install (#707) * add new warning prompt for non-trusted publishers during ext:install * clean up param namne * clean up comment * switch from author ulr to sourceUrl * no please * Update copy to link user to documentation on ext:install flow if input not found (#711) * Adds console install link to ext:dev:publish (#709) * Adds console install link to ext:dev:publish * formats * Add firebase ext:dev:delete command to CLI (#712) * adds changelog * formats Co-authored-by: huangjeff5 <[email protected]> Co-authored-by: Jeff Huang <[email protected]> Co-authored-by: Elvis Sun <[email protected]>
devpeerapong
pushed a commit
to devpeerapong/firebase-tools
that referenced
this pull request
Dec 14, 2021
* Add publisher to registry file fields (firebase#686) * Migrate ext:update ref-based flow to include update warnings + min extension version guard (firebase#684) * Migrate ext:install flow to install via extension reference and remove EAP gating (firebase#679) * Remove EAP-specific copy in ext:dev:register and ext:dev:publish command (firebase#691) * Warn user that unpublishing is final in ext:dev:unpublish command (firebase#693) * Add extMinVersion flag to ext:dev:unpublish command (firebase#698) * Migrate ext:info flow to retrieve spec from Registry API (firebase#683) * Migrate "author" terminology to use "publisher" in Extensions CLI commands (firebase#694) * Fix bug in confirmInstallByReference and refactor ext:install error messages (firebase#702) * Fix local path detection logic and refactor warnings logic in ext:update flow (firebase#703) * Migrate extensions warnings relating to audiences to use (backend) launch stage and visibility fields (firebase#705) * Only infer firebase if publisher not provided as part of user input in ext:info flow (firebase#708) * Adds new warning prompt for non-trusted publishers during ext:install (firebase#707) * add new warning prompt for non-trusted publishers during ext:install * clean up param namne * clean up comment * switch from author ulr to sourceUrl * no please * Update copy to link user to documentation on ext:install flow if input not found (firebase#711) * Adds console install link to ext:dev:publish (firebase#709) * Adds console install link to ext:dev:publish * formats * Add firebase ext:dev:delete command to CLI (firebase#712) * adds changelog * formats Co-authored-by: huangjeff5 <[email protected]> Co-authored-by: Jeff Huang <[email protected]> Co-authored-by: Elvis Sun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this change, the predeploy commands fail with an unhelpful error if you try to run the command from a directory with spaces in the name. Using double quotes when expanding $RESOURCE_DIR guarantees that the variable expands to a single parameter, instead of being split on spaces.
This should fix #658.
Scenarios Tested
All tests from "npm test" pass.
I can reproduce the error from #658 (predeploy error during
firebase deploy) if I initialize the firebase directory in a directory that has a space anywhere in its full path. If I use these predeploy hooks instead, the deploy succeeds.Sample Commands
This PR does not change any commands, it just fixes the default predeploy hooks.