Fix emulator support for cloudevent to better conform to production specification. #5466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 26, 2023
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
taeold
requested review from
Salakar,
TheIronDev,
Berlioz,
blidd-google and
colerogers
colerogers
approved these changes
Jan 30, 2023
taeold
force-pushed
the
dl_cf3_python_init
branch
from
c8d8bbb to
02af491
Compare
taeold
force-pushed
the
dl_emulator_fixes
branch
from
de008c4 to
2951641
Compare
|
⏳ This pull request is set to merge as part of a Graphite merge job |
taeold
force-pushed
the
dl_cf3_python_init
branch
from
02af491 to
c2e179f
Compare
taeold
force-pushed
the
dl_emulator_fixes
branch
from
2951641 to
88395f3
Compare
taeold
force-pushed
the
dl_cf3_python_init
branch
from
c2e179f to
d0028a7
Compare
taeold
force-pushed
the
dl_emulator_fixes
branch
from
59f9fb9 to
e081eec
Compare
taeold
force-pushed
the
dl_cf3_python_init
branch
from
d0028a7 to
e1fc3bf
Compare
taeold
force-pushed
the
dl_emulator_fixes
branch
from
eae4352 to
ce4f5cc
Compare
taeold
force-pushed
the
dl_emulator_fixes
branch
from
28141c2 to
9e79209
Compare
Codecov ReportBase: 56.24% // Head: 56.22% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5466 +/- ##
==========================================
- Coverage 56.24% 56.22% -0.02%
==========================================
Files 317 317
Lines 21435 21442 +7
Branches 4376 4376
==========================================
Hits 12056 12056
- Misses 8319 8326 +7
Partials 1060 1060
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix few bugs in emulator support for cloudevent that was uncovered while testing python functions.
Pubsub emulator sends timestamps with nano-second precision, not mili-second precision as done in Production. Not usually a problem, but the the ISO timestamp parsing function for Python doesn't work with timestamps with nano-second precision.
specversionattribute of cloudevent should be1.0not1Pubsub cloudevent should include snake_cased AND camelCase event attributes.
Also including a small change to improve debugging experience when discovering python functions fail due to user error - e.g. python code includes syntax error.