-
Notifications
You must be signed in to change notification settings - Fork 960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce function timeout at worker level. #5464
Conversation
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
562b33e
to
e1820fb
Compare
Codecov ReportBase: 56.30% // Head: 56.29% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5464 +/- ##
==========================================
- Coverage 56.30% 56.29% -0.01%
==========================================
Files 315 315
Lines 21348 21366 +18
Branches 4353 4361 +8
==========================================
+ Hits 12020 12029 +9
+ Misses 8287 8286 -1
- Partials 1041 1051 +10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
e1820fb
to
d1a42b2
Compare
d1a42b2
to
02ef09d
Compare
this.id = uuid.v4(); | ||
this.key = key; | ||
this.triggerKey = triggerId || "~free~"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we make "~free"
a const?
⏳ This pull request is set to merge as part of a Graphite merge job |
02ef09d
to
5dafafe
Compare
5dafafe
to
7a3e720
Compare
7a3e720
to
ffd7644
Compare
Function timeout for emulator was enforced by the emulated function process.
Here we pull out the timeout enforcement at the worker level (analogous to "Data Plane" in production environment). When timeout is reached, the worker will abort the triggering request and kill the child process.
This refactor will remove the need to write code for enforcing timeout for emulated python functions.