Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to initialize python functions. #5465

Merged
merged 5 commits into from
Jan 31, 2023
Merged

Conversation

taeold
Copy link
Contributor

@taeold taeold commented Jan 25, 2023

Add Python as an option for firebase init functions.

The python choice is guarded behind the pythonfunctions experiment. You can enable the experiment with firebase experiments:enable pythonfunctions.

This PR is a fork of #4653. With this PR, #4653 is now obsolete.

@taeold taeold force-pushed the dl_emulator_timeout branch from e1820fb to d1a42b2 Compare January 25, 2023 21:34
@taeold taeold force-pushed the dl_cf3_python_init branch from fb649ea to 1fa83d8 Compare January 25, 2023 21:34
@codecov-commenter
Copy link

Codecov Report

Base: 56.29% // Head: 56.29% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (1fa83d8) compared to base (d1a42b2).
Patch coverage: 64.28% of modified lines in pull request are covered.

Additional details and impacted files
@@                   Coverage Diff                   @@
##           dl_emulator_timeout    #5465      +/-   ##
=======================================================
- Coverage                56.29%   56.29%   -0.01%     
=======================================================
  Files                      315      315              
  Lines                    21366    21372       +6     
  Branches                  4361     4363       +2     
=======================================================
+ Hits                     12029    12032       +3     
- Misses                    8286     8288       +2     
- Partials                  1051     1052       +1     
Impacted Files Coverage Δ
src/functions/python.ts 38.46% <0.00%> (-3.21%) ⬇️
src/init/features/functions/index.ts 80.76% <33.33%> (-1.90%) ⬇️
src/deploy/functions/runtimes/python/index.ts 35.61% <80.00%> (+1.81%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

#
# @https.on_request()
# def on_request_example(req: https.Request) -> https.Response:
# return https.Response("Hello world!")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline at eof

@taeold taeold force-pushed the dl_emulator_timeout branch from d1a42b2 to 02ef09d Compare January 30, 2023 21:57
@taeold taeold force-pushed the dl_cf3_python_init branch from c8d8bbb to 02af491 Compare January 30, 2023 21:57
@taeold
Copy link
Contributor Author

taeold commented Jan 31, 2023

⏳ This pull request is set to merge as part of a Graphite merge job
Stack job ID: aDBFOYKNmnzR1pnl7vJM.
See details on graphite.dev

@taeold taeold force-pushed the dl_emulator_timeout branch from 02ef09d to 5dafafe Compare January 31, 2023 18:05
@taeold taeold force-pushed the dl_cf3_python_init branch from 02af491 to c2e179f Compare January 31, 2023 18:06
@taeold taeold force-pushed the dl_emulator_timeout branch from 5dafafe to 7a3e720 Compare January 31, 2023 22:56
@taeold taeold force-pushed the dl_cf3_python_init branch from c2e179f to d0028a7 Compare January 31, 2023 22:56
@taeold taeold force-pushed the dl_emulator_timeout branch from 7a3e720 to ffd7644 Compare January 31, 2023 23:10
@taeold taeold force-pushed the dl_cf3_python_init branch from d0028a7 to e1fc3bf Compare January 31, 2023 23:10
Base automatically changed from dl_emulator_timeout to master January 31, 2023 23:30
@taeold taeold merged commit 7dc6c5b into master Jan 31, 2023
@taeold taeold deleted the dl_cf3_python_init branch January 31, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants