Fix: Fixed issue with resizing the status column

[ferrariofilippo]

…olumns

Resolved / Related Issues
Items resolved / related issues by this PR.

• Closes Bug: Recycle bin original path and data deleted columns are set to 0 width #11103
• Closes Feature: Allow resizing the status column #10432
• Related Fix: Original path and date deleted column sizes aren't saved #10585
• Related Only save necessary info to folder preferences #10560
• Related Feature: Added option to set default column sizes #10117
• Related Fix: Fixed issue where columns sometimes had no width #10239

Comments

• I added a null check in Win32Shell to avoid an exception that was getting me mad
• To fix this bug we need to save the default size only when the column is visible. We have two ways to achieve this:
  • We can check if each column is actually visible (is not collapsed and has width > 0) -> This is what i proposed in this PR
  • We can use the less readable and less understandable, but faster approach I first proposed in Feature: Added option to set default column sizes #10117 (see Unresolved Conversation). I may add a comment to the first width setter that specify when width = 0

Let me know what you think

Validation
How did you test these changes?

• Built and ran the app
• Tested the changes for accessibility

[yaira2]

How is it different than any of the other columns that can be hidden, can't we reuse the logic?

[ferrariofilippo]

How is it different than any of the other columns that can be hidden, can't we reuse the logic?

The problem was that Hidden columns were not Collapsed, and so their sizes were saved. I changed the logic so that when a column is hidden it's collapsed too.

[yaira2]

Does this fix #11025?

[ferrariofilippo]

Does this fix #11025?

It doesn't

[yaira2]

LGTM

[yaira2]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).