Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fixed issue where columns sometimes had no width #10239

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Fix: Fixed issue where columns sometimes had no width #10239

merged 1 commit into from
Oct 19, 2022

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

Comments
There was a bug involving hidden columns.
Steps to reproduce:

  • Hide at least one column
  • Set column widths as default
  • Show one of the hidden columns
  • See that its width is 0px

Validation
How did you test these changes?

  • Built and ran the app

@ferrariofilippo ferrariofilippo mentioned this pull request Oct 17, 2022
Merged
1 task
@yaira2 yaira2 changed the title Fixed a bug of default column widths Fix: Removed max width from the name column Oct 19, 2022
@yaira2 yaira2 changed the title Fix: Removed max width from the name column Fixed a bug of default column widths Oct 19, 2022
@yaira2 yaira2 changed the title Fixed a bug of default column widths Fix: Fixed issue where columns sometimes had no width Oct 19, 2022
yaira2
yaira2 approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Oct 19, 2022
@yaira2 yaira2 merged commit aac56a4 into files-community:main Oct 19, 2022
@ferrariofilippo ferrariofilippo deleted the Fix_Default_Column_Widths branch October 19, 2022 07:26
This was referenced Jan 16, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ferrariofilippo @yaira2