Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Allow resizing the status column #10432

Closed
ferrariofilippo opened this issue Nov 8, 2022 · 5 comments · Fixed by #10513 or #11027
Closed

Feature: Allow resizing the status column #10432

ferrariofilippo opened this issue Nov 8, 2022 · 5 comments · Fixed by #10513 or #11027

Comments

@ferrariofilippo
Copy link
Contributor

Description

Status column cannot be resized by the user.

Steps To Reproduce

  1. Open OneDrive folder
  2. Try to resize Status column

Steps to fix

User should be able resize Status column

Files Version

Version: 2.3.55.0 OS Version: 10.0.22621.755

Windows Version

Windows 11 Home Version 22H2 22621.755

Relevant Assets/Logs

Headers

@gave92
Copy link
Member

gave92 commented Nov 8, 2022

That's on purpose as the contents of that column are fixed width (it's just an icon). The header text being cut is kinda ugly though.

@yaira2 yaira2 closed this as completed Nov 8, 2022
Repository owner moved this from 🆕 New to ✅ Done in Files task board Nov 8, 2022
@ferrariofilippo
Copy link
Contributor Author

I was browsing the code and I noticed that still it has a GridSplitter.
I think we should remove it since we don't really need it.
At the moment it's not visible since its width is set to 0

@yaira2
Copy link
Member

yaira2 commented Nov 8, 2022

We might as well make it resizable to be consistent with the other columns.

@yaira2 yaira2 reopened this Nov 8, 2022
Repository owner moved this from ✅ Done to 🆕 New in Files task board Nov 8, 2022
@yaira2 yaira2 changed the title Bug: Sync Status column cannot be resized Feature: Allow resizing the status column Nov 8, 2022
@yaira2 yaira2 added feature request and removed bug labels Nov 8, 2022
@yaira2 yaira2 moved this from 🆕 New to 🔖 Ready to build in Files task board Nov 8, 2022
Repository owner moved this from 🔖 Ready to build to ✅ Done in Files task board Nov 24, 2022
@ferrariofilippo
Copy link
Contributor Author

@yaira2 can you reopen this? It's still a problem. I'll check commit history to see when it was changed

@Josh65-2201 Josh65-2201 reopened this Jan 15, 2023
@github-project-automation github-project-automation bot moved this from ✅ Done to 🆕 New in Files task board Jan 15, 2023
@Josh65-2201 Josh65-2201 moved this from 🆕 New to 🔖 Ready to build in Files task board Jan 15, 2023
@ferrariofilippo
Copy link
Contributor Author

ferrariofilippo commented Jan 16, 2023

So, I analyzed the problem. I concluded that it is actually possible to resize Sync Status but only when its size is greater than 0. The real problem is that the column may have a width of 0 (this affects other folder-specific columns, such as Deletion Date). Now I need to figure out if this happens when the user clicks Set as default or when he restores overrides.
Edit. I think this first problem may be caused by #10585, #10117 and #10239 (involves Set as Default)

There is also another bug reintroduced with #10560: because we do not save NormalMaxWidth, the columns have no maximum width constraint after being resized.
To reproduce this problem:

  • Open a folder where you can view the Sync Status column (e.g., OneDrive).
  • Resize the Sync Status column.
  • Change folder and then go back to the first folder (in this example, OneDrive), this will reload columns settings.
  • Try resizing the Sync Status column and see that there is no longer any width constraint

@Josh65-2201 Josh65-2201 moved this from 🔖 Ready to build to 🏗 In progress in Files task board Jan 16, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Files task board Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
4 participants