splitstore sortless compaction #8008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8008 +/- ##
==========================================
- Coverage 39.27% 39.12% -0.15%
==========================================
Files 660 662 +2
Lines 71436 71922 +486
==========================================
+ Hits 28054 28143 +89
- Misses 38580 38887 +307
- Partials 4802 4892 +90
Continue to review full report at Codecov.
|
vyzo
changed the title
This was referenced Feb 4, 2022
This was referenced Feb 7, 2022
…t-markset-badger splitstore: set badger as the default default markset type
Adds note about 3k IOPs requirement with badger markset, updates the memory requirement for map to 48G based on observed behaviour of test nodes.
magik6k
approved these changes
Feb 9, 2022
|
⛵ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements sortless compaction, as outlined in #7137.
Closes #7137
The compaction algorithm is modified to store the coldset on disk and checkpoint deletions. Once the critical section starts, the markset is consulted on reads and an object is considered as missing from the hotstore if it is not in the markset, while write synchronously update the markset.
This results in significantly faster compaciton (40% of time was spent in sorting).
In addition, coupled with the badger markset, compaction now uses very little memory independent of coldset size, which makes it possible to use the splitstore in memory constrained systems.