Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

splistore cold object reification redux #8029

Merged
merged 12 commits into from
Feb 14, 2022

Conversation

vyzo
Copy link
Contributor

@vyzo vyzo commented Feb 4, 2022

Implements cold object reification in the splitstore for VM access, as described in #6726; on top of #8008, cherry picked and adapted from #6914.
Closes #6726

@vyzo vyzo requested a review from magik6k February 4, 2022 14:23
@vyzo vyzo requested a review from a team as a code owner February 4, 2022 14:23
@vyzo vyzo added this to the █Blockstore Improvements milestone Feb 4, 2022
@vyzo vyzo linked an issue Feb 4, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #8029 (6bcade5) into master (049b489) will increase coverage by 0.06%.
The diff coverage is 61.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8029      +/-   ##
==========================================
+ Coverage   39.20%   39.27%   +0.06%     
==========================================
  Files         662      664       +2     
  Lines       71925    72056     +131     
==========================================
+ Hits        28201    28301     +100     
+ Misses      38839    38837       -2     
- Partials     4885     4918      +33     
Impacted Files Coverage Δ
blockstore/splitstore/splitstore_reify.go 53.63% <53.63%> (ø)
blockstore/context.go 100.00% <100.00%> (ø)
blockstore/splitstore/splitstore.go 41.47% <100.00%> (+18.50%) ⬆️
chain/consensus/filcns/compute_state.go 74.11% <100.00%> (+0.15%) ⬆️
markets/loggers/loggers.go 88.88% <0.00%> (-11.12%) ⬇️
extern/storage-sealing/sector_state.go 92.30% <0.00%> (-7.70%) ⬇️
chain/events/observer.go 71.64% <0.00%> (-6.72%) ⬇️
markets/retrievaladapter/client_blockstore.go 62.50% <0.00%> (-6.25%) ⬇️
chain/stmgr/execute.go 86.95% <0.00%> (-4.35%) ⬇️
chain/messagepool/repub.go 51.61% <0.00%> (-4.31%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 049b489...6bcade5. Read the comment docs.

Base automatically changed from feat/splitstore-sortless-compaction to master February 9, 2022 17:17
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some mostly questions. Would be good to put answers in code comments as well so that future readers will be less confused.

blockstore/splitstore/splitstore_reify.go Show resolved Hide resolved
blockstore/splitstore/splitstore_reify.go Show resolved Hide resolved
blockstore/splitstore/splitstore_reify.go Show resolved Hide resolved
blockstore/splitstore/splitstore.go Show resolved Hide resolved
blockstore/context.go Outdated Show resolved Hide resolved
@magik6k magik6k merged commit 7efed66 into master Feb 14, 2022
@magik6k magik6k deleted the feat/splistore-cold-object-reification-redux branch February 14, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Splitstore: reification of cold objects
3 participants