Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

splitstore: set badger as the default default markset type #8034

Conversation

vyzo
Copy link
Contributor

@vyzo vyzo commented Feb 6, 2022

On top of #8008.

Sets badger as the default markset type, so that we can work out of the box if we have <40G of RAM.

@vyzo vyzo requested a review from magik6k February 6, 2022 09:29
@vyzo vyzo requested a review from a team as a code owner February 6, 2022 09:29
@vyzo vyzo added this to the █Blockstore Improvements milestone Feb 6, 2022
@codecov
Copy link

codecov bot commented Feb 6, 2022

Codecov Report

Merging #8034 (0ad1f0e) into feat/splitstore-sortless-compaction (049b489) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                           Coverage Diff                           @@
##           feat/splitstore-sortless-compaction    #8034      +/-   ##
=======================================================================
- Coverage                                39.20%   39.15%   -0.06%     
=======================================================================
  Files                                      662      662              
  Lines                                    71925    71925              
=======================================================================
- Hits                                     28201    28160      -41     
- Misses                                   38839    38881      +42     
+ Partials                                  4885     4884       -1     
Impacted Files Coverage Δ
node/config/def.go 97.46% <100.00%> (ø)
markets/loggers/loggers.go 88.88% <0.00%> (-11.12%) ⬇️
extern/storage-sealing/sector_state.go 92.30% <0.00%> (-7.70%) ⬇️
chain/actors/builtin/miner/diff.go 52.94% <0.00%> (-5.89%) ⬇️
chain/stmgr/execute.go 86.95% <0.00%> (-4.35%) ⬇️
chain/messagepool/repub.go 51.61% <0.00%> (-4.31%) ⬇️
chain/stmgr/call.go 67.87% <0.00%> (-3.64%) ⬇️
extern/storage-sealing/states_replica_update.go 37.14% <0.00%> (-3.58%) ⬇️
extern/storage-sealing/states_failed.go 0.00% <0.00%> (-3.39%) ⬇️
chain/sub/incoming.go 54.43% <0.00%> (-3.38%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 049b489...0ad1f0e. Read the comment docs.

@magik6k magik6k merged commit 966071d into feat/splitstore-sortless-compaction Feb 7, 2022
@magik6k magik6k deleted the feat/splitstore-default-markset-badger branch February 7, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants