Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not enough room for more text #2

Closed
fenhl opened this issue May 4, 2022 · 2 comments
Closed

Not enough room for more text #2

fenhl opened this issue May 4, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@fenhl
Copy link
Owner

fenhl commented May 4, 2022

I had to revert the changes to text boxes from OoTRandomizer#1563 on this branch because it resulted in seeds failing to generate if shops are shuffled because too much text is added to the game. Changes similar to the ones made in OoTRandomizer#1126 but for the text data itself rather than the table of text box IDs might fix this.
@fenhl fenhl added the bug Something isn't working label May 4, 2022
@fenhl
Copy link
Owner Author

fenhl commented May 4, 2022

See also OoTRandomizer#744 which removed a previous (broken) attempt at this.

fenhl pushed a commit that referenced this issue Jun 1, 2022
@Jaybone25
Merge pull request #2 from fenhl/ganon-er-bridge-goals
4433a6d 
Disable bridge goals if Ganon's Castle is shuffled
fenhl pushed a commit that referenced this issue Aug 19, 2022
@cjohnson57
Merge 'Revert removal of dungeon summary menu Take #2' (OoTRandomizer…
668abd6 
…#1680)
fenhl pushed a commit that referenced this issue Oct 20, 2022
@cjohnson57
Merge pull request #2 from Maplesstar/models, ty maple
2aefffd 
Add Tooltip for Model Selection
@fenhl
Copy link
Owner Author

fenhl commented Jan 26, 2023 •
edited
Loading

Fixed in OoTRandomizer#1837.

@fenhl fenhl closed this as completed Jan 26, 2023
fenhl pushed a commit that referenced this issue Mar 6, 2023
@Elagatua
Merge pull request #2 from Elagatua/feature/prioritize-dungeon-hints
f35597b 
Prioritize dungeon locations for path and barren hints
fenhl pushed a commit that referenced this issue Jun 18, 2023
@DobbyDigital
Merge pull request #2 from TestRunnerSRL/Dev
e53760c 
Update fork to latest Dev
fenhl pushed a commit that referenced this issue Jun 20, 2023
@r0bd0g
Merge pull request #2 from jdunn596/Logic
284f836 
Update tests
fenhl pushed a commit that referenced this issue Jul 15, 2024
@shirosoluna
Merge pull request #2 from dotzo/no-logic-preset
bc93ee6 
formatting changes for ci.py pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fenhl