Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages.py clean-ups #744

Merged
merged 2 commits into from
Jun 17, 2019
Merged

Conversation

mzxrules
Copy link

  • Expand nes_message_data_static to it's maximum size before overwriting the staff messages and removed the broken spillover to jpn_message_data_static. If the extra space is still not enough, let me know.
  • Greatly simplified Message.size() and Message.write() by implementing Message.transform(), which modifies the message's text_code list before writing back.
  • Text shuffle now accepts the message list, instead of waiting for all dialogs to be written back and then read from rom again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants