Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert removal of dungeon summary menu Take #2 #1680

Merged
merged 5 commits into from
Aug 18, 2022

Conversation

mracsys
Copy link

@mracsys mracsys commented Aug 18, 2022

Re-opened after consensus on the ootr discord.

Add the A button menu back into the game. Overall size is shrunk to better fit on screens with overscan. This includes a check to remove dungeon reward icons from the summary if mixed entrance pools is a valid option and Boss type entrances are mixed.

Having one screen with all of the info is more convenient than three submenus. It is also easier in my opinion to hold the A button than a specific d-pad direction.

Tested on PJ64, N64, and Wii VC.

This also includes a minor fix to prevent the d-pad icons from flashing between the boots and dungeon icons when equipping items on C buttons. D-pad boots/ocarina inputs on pause/unpause are preserved.

Menu with at least one entry in every slot:
image

Text legibility on N64:
image

@r0bd0g
Copy link

r0bd0g commented Aug 18, 2022

N64 res is a little rough. Can you show me what all of the numbers look like?

@ETR-BTF
Copy link

ETR-BTF commented Aug 18, 2022

N64 res is a little rough. Can you show me what all of the numbers look like?

In particular I'm curious about how the 3 looks next to an 8, and maybe 8 & 9 too.

What does this PR do to the d-pad menus? Are they still around? Are they disabled?

Is there room to add a little bit of black space or maybe even a line or something underneath certain rows? Like for example adding a little bit of space between Jabu and Forest and between Spirit and BotW might improve readability.

@cjohnson57
Copy link
Collaborator

D-Pad menu is untouched.

@cjohnson57 cjohnson57 added the Component: ASM/C Changes some internals of the ASM/C libraries label Aug 18, 2022
@mracsys
Copy link
Author

mracsys commented Aug 18, 2022

As-is, 0's and 8's are hard to tell apart:

image

Changing the 0's to capital O's, it's clearer and doesn't look odd:

image

For comparison, the d-pad key menu (unchanged):

image

Also note that my capture card is darker than the TV image. On my TV the 5, 7, F, T, and I all have clear top lines instead of looking like they are chopped off.

@cjohnson57
Copy link
Collaborator

Yeah, the O is thin enough that it still looks like a 0, It'd make sense to change it to that (although if you do then you should change it for the other menu too for consistency)

@cjohnson57
Copy link
Collaborator

One last thing I just noticed, when I go to the key menu there are what look like backslashes on the right of the screen for some reason, they're only there on that menu and only on this branch as far as I can tell.
image

@cjohnson57 cjohnson57 merged commit 668abd6 into OoTRandomizer:Dev Aug 18, 2022
@mracsys mracsys deleted the combined-dungeon-menu branch November 10, 2022 01:19
@fenhl fenhl added this to the 7.0 milestone Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: ASM/C Changes some internals of the ASM/C libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants