Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified database adapters #170

Closed
7 tasks done
daffl opened this issue Nov 7, 2015 · 13 comments
Closed
7 tasks done

Unified database adapters #170

daffl opened this issue Nov 7, 2015 · 13 comments
Assignees
Milestone

Comments

@daffl
Copy link
Member

daffl commented Nov 7, 2015

Here is a list of all official supported database and ORM service adapters. Checked off adapters have been completely migrated to the common querying mechanism (see feathers-service-tests), ES6 classes, promises and verified with working examples:

Standalone services:

ORMs:

@marshallswain
Copy link
Member

Do we want to add RethinkDB to this list?

@daffl
Copy link
Member Author

daffl commented Nov 19, 2015

Yes. I had a chat with @ekryski this week and we were thinking of supporting multiple ORMs (Waterline, Mongoose, Sequelize and Knex) instead of multiple specific database adapters. This would make it easier to maintain and give us a lot of databases plus things like GraphQL for free.
However, none of those seem to really support RethinkDB so we definitely need that adapter. What was the name of the RethinkDB ORM you mentioned?

@marshallswain
Copy link
Member

Thinky
On Thu, Nov 19, 2015 at 12:11 AM David Luecke [email protected]
wrote:

Yes. I had a chat with @ekryski https://github.com/ekryski this week
and we were thinking of supporting multiple ORMs (Waterline, Mongoose,
Sequelize and Knex) instead of multiple specific database adapters. This
would make it easier to maintain and give us a lot of databases plus things
like GraphQL for free.
However, none of those seem to really support RethinkDB so we definitely
need that adapter. What was the name of the RethinkDB ORM you mentioned?


Reply to this email directly or view it on GitHub
#170 (comment)
.

@daffl
Copy link
Member Author

daffl commented Nov 25, 2015

@marshallswain @ekryski I updated the list of the officially supported databases and ORM adapters, let me know if that makes sense.

I am also inclined of migrating everything to ES6 classes and use of Promises (Feathers supports services that return a Promise since v1 and it should probably also become the default for v2). That way everything would be lined up for Feathers 2. The API would be mostly the same but it will break Uberproto's .extend which I think would be ok as long as it will be a respective new major release.

@marshallswain
Copy link
Member

Looks good. I love how many DBs we get with the ORMs. This is a good move.

@ekryski
Copy link
Contributor

ekryski commented Nov 25, 2015

Looks good. 👍 for the call to move to ORMs.

@daffl daffl removed this from the 1.2.0 milestone Dec 16, 2015
@ekryski ekryski added this to the 2.0.0 milestone Dec 17, 2015
@ekryski ekryski self-assigned this Dec 17, 2015
@ekryski
Copy link
Contributor

ekryski commented Dec 21, 2015

I just pushed an update to feathers-waterline. From my manual testing everything appears to be working but I'm unable to get our common test suite passing because of Waterline's async initialization.

Help getting tests to pass would be appreciated. 😄

@ekryski
Copy link
Contributor

ekryski commented Dec 21, 2015

Just updated feathers-knex. Making good progress. Hope to have mongoose done later today as well.

@ekryski
Copy link
Contributor

ekryski commented Dec 28, 2015

Feathers-waterline is up to date and has been released. Woop Woop!

Just wrapping up the updates to feathers-mongoose.

@ekryski
Copy link
Contributor

ekryski commented Jan 4, 2016

feathers-mongoose v3.0.0 is now out and is up to date.

@ekryski
Copy link
Contributor

ekryski commented Jan 6, 2016

feathers-nedb v2.0.0 is now published. It was brought up to date by PR feathersjs-ecosystem/feathers-nedb#8.

@ekryski
Copy link
Contributor

ekryski commented Jan 13, 2016

So because we already have feathers-mongoose and feathers-waterline and we've found that most people want to work with an ORM it doesn't really make sense to have yet another mongodb adapter. Plus the native adapter's API is very tough to work with.

It can follow after the 2.0 release if required but it shouldn't hold it up. I've created feathersjs-ecosystem/feathers-mongodb#16 and feathersjs-ecosystem/feathers-mongodb#17 to track that progress.

@ekryski ekryski closed this as completed Jan 13, 2016
@lock
Copy link

lock bot commented Feb 8, 2019

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue with a link to this issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants