-
-
Notifications
You must be signed in to change notification settings - Fork 761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified database adapters #170
Comments
Do we want to add RethinkDB to this list? |
Yes. I had a chat with @ekryski this week and we were thinking of supporting multiple ORMs (Waterline, Mongoose, Sequelize and Knex) instead of multiple specific database adapters. This would make it easier to maintain and give us a lot of databases plus things like GraphQL for free. |
Thinky
|
@marshallswain @ekryski I updated the list of the officially supported databases and ORM adapters, let me know if that makes sense. I am also inclined of migrating everything to ES6 classes and use of Promises (Feathers supports services that return a Promise since v1 and it should probably also become the default for v2). That way everything would be lined up for Feathers 2. The API would be mostly the same but it will break Uberproto's |
Looks good. I love how many DBs we get with the ORMs. This is a good move. |
Looks good. 👍 for the call to move to ORMs. |
I just pushed an update to feathers-waterline. From my manual testing everything appears to be working but I'm unable to get our common test suite passing because of Waterline's async initialization. Help getting tests to pass would be appreciated. 😄 |
Just updated feathers-knex. Making good progress. Hope to have mongoose done later today as well. |
Feathers-waterline is up to date and has been released. Woop Woop! Just wrapping up the updates to feathers-mongoose. |
feathers-mongoose v3.0.0 is now out and is up to date. |
feathers-nedb v2.0.0 is now published. It was brought up to date by PR feathersjs-ecosystem/feathers-nedb#8. |
So because we already have feathers-mongoose and feathers-waterline and we've found that most people want to work with an ORM it doesn't really make sense to have yet another mongodb adapter. Plus the native adapter's API is very tough to work with. It can follow after the 2.0 release if required but it shouldn't hold it up. I've created feathersjs-ecosystem/feathers-mongodb#16 and feathersjs-ecosystem/feathers-mongodb#17 to track that progress. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue with a link to this issue for related bugs. |
Here is a list of all official supported database and ORM service adapters. Checked off adapters have been completely migrated to the common querying mechanism (see feathers-service-tests), ES6 classes, promises and verified with working examples:
Standalone services:
MongoDB- we already have mongoose and waterline.RethinkDB- It's not ready yet and can be released later.ORMs:
The text was updated successfully, but these errors were encountered: