Migration to new service tests and ES6 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Create the service. | ||
| class Service { | ||
| constructor(options = {}) { | ||
| if(!options.db) { |
There was a problem hiding this comment.
To normalize with the other db adapters this should be options.Model. Then it will make it much easier for us to generate.
ekryski
added a commit
that referenced
this pull request
Jan 6, 2016
Migration to new service tests and ES6
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With updated documentation and example. There still is some weird counter sorting that we I have to do for some reason. I will track it in a separate issue but since it seems to be how NeDB always behaved it shouldn't break anything.