-
-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate new feathers-errors into database adapters #182
Comments
I just pushed an update for feathers-waterline. The error integration seems good but they are a little hard to test because they aren't easily exposed in Waterline and those guys are doing some gnarly prototype hacks on the error objects. |
I've integrated errors at least for SQLite into Knex. Knex just proxies the errors that come back from each db, so we'll need to map the db driver's errors. Quite a bit of work but can probably happen over time. |
Errors are integrated into Mongoose. Just waiting on some final touches before the PR lands. |
Errors are integrated into NeDB. Just MongoDB to go!!! |
So because we already have feathers-mongoose and feathers-waterline and we've found that most people want to work with an ORM it doesn't really make sense to have yet another mongodb adapter. Plus the native adapter's API is very tough to work with. It can follow after the 2.0 release if required but it shouldn't hold it up. I've created feathersjs-ecosystem/feathers-mongodb#16 and feathersjs-ecosystem/feathers-mongodb#17 to track that progress. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue with a link to this issue for related bugs. |
We've converted feathers-errors to use ES6 and changed how they are exposed.
We also need to map ORM errors to Feathers errors so that they all have a consistent format and preserve the correct error codes.
DBs/ORMs
MongoDB- we already have mongoose and waterline.RethinkDB- It's not ready yet.This goes hand in hand with #170.
The text was updated successfully, but these errors were encountered: