Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate new feathers-errors into database adapters #182

Closed
8 tasks done
ekryski opened this issue Dec 17, 2015 · 6 comments
Closed
8 tasks done

Integrate new feathers-errors into database adapters #182

ekryski opened this issue Dec 17, 2015 · 6 comments
Assignees
Milestone

Comments

@ekryski
Copy link
Contributor

ekryski commented Dec 17, 2015

We've converted feathers-errors to use ES6 and changed how they are exposed.

We also need to map ORM errors to Feathers errors so that they all have a consistent format and preserve the correct error codes.

DBs/ORMs

  • Memory
  • Sequelize
  • Knex
  • Mongoose
  • Waterline
  • MongoDB - we already have mongoose and waterline.
  • NeDB
  • RethinkDB - It's not ready yet.

This goes hand in hand with #170.

@ekryski ekryski added this to the 2.0.0 milestone Dec 17, 2015
@ekryski ekryski self-assigned this Dec 17, 2015
@ekryski
Copy link
Contributor Author

ekryski commented Dec 21, 2015

I just pushed an update for feathers-waterline. The error integration seems good but they are a little hard to test because they aren't easily exposed in Waterline and those guys are doing some gnarly prototype hacks on the error objects.

@ekryski
Copy link
Contributor Author

ekryski commented Dec 21, 2015

I've integrated errors at least for SQLite into Knex. Knex just proxies the errors that come back from each db, so we'll need to map the db driver's errors. Quite a bit of work but can probably happen over time.

@ekryski
Copy link
Contributor Author

ekryski commented Dec 30, 2015

Errors are integrated into Mongoose. Just waiting on some final touches before the PR lands.

@ekryski
Copy link
Contributor Author

ekryski commented Jan 6, 2016

Errors are integrated into NeDB. Just MongoDB to go!!!

@ekryski
Copy link
Contributor Author

ekryski commented Jan 13, 2016

So because we already have feathers-mongoose and feathers-waterline and we've found that most people want to work with an ORM it doesn't really make sense to have yet another mongodb adapter. Plus the native adapter's API is very tough to work with.

It can follow after the 2.0 release if required but it shouldn't hold it up. I've created feathersjs-ecosystem/feathers-mongodb#16 and feathersjs-ecosystem/feathers-mongodb#17 to track that progress.

@lock
Copy link

lock bot commented Feb 8, 2019

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue with a link to this issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant