Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This reverts #18899 and re-enables #18897.
The issue is caused by eslint/eslint#12888 because ESLint v7 ignores
node_modules/*
in subdirectories.To fix this, I've add
!/build/node_modules/*
intoeslintignore
for the rollup validate script.I've tested this with
yarn lint-build
. Is there anything else I have to test?Should I add a check to run
yarn lint-build
at every PRs?Test Plan
yarn lint-build