deps: bump ESLint version to v7 #18897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 648124e:
|
This was referenced May 12, 2020
|
All checks have passed🚀 |
|
thank you |
|
This is now causing master to fail because during our validation script we get the error: Oddly, there are definitely files in there, as it states this just above. Any ideas? |
gaearon
added a commit
that referenced
this pull request
May 12, 2020
|
@gaearon oh, I’ll work on it now! |
koba04
added a commit
to koba04/react
that referenced
this pull request
May 12, 2020
…acebook#18899)" This reverts commit 84fd4b8.
koba04
added a commit
to koba04/react
that referenced
this pull request
May 15, 2020
…acebook#18899)" This reverts commit 84fd4b8.
gaearon
pushed a commit
that referenced
this pull request
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is to update ESLint version in
devDependenciesto v7.The motivation is to verify whether
eslint-plugin-react-hooksworks fine with ESLint v7.#18878 is a PR to bump the peerDependencies version, but it doesn't guarantee the behavior with ESLint v7.
I've also fixed some failed tests with ESLint v7.
The fails are caused by eslint/eslint#12955, which makes
outputrequire when the rule has fixed the code.Test Plan
yarn test&&yarn lint