Revert "deps: update ESLint version to v7 (facebook#18897)" (facebook…

…#18899) This reverts commit 039ad34.
koba04 · May 12, 2020 · 84fd4b8 · 84fd4b8
1 parent 14e554b
commit 84fd4b8
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 158 deletions.
diff --git a/package.json b/package.json
@@ -47,7 +47,7 @@
     "cross-env": "^6.0.3",
     "danger": "^9.2.10",
     "error-stack-parser": "^2.0.6",
-    "eslint": "^7.0.0",
+    "eslint": "^6.8.0",
     "eslint-config-fbjs": "^1.1.1",
     "eslint-config-prettier": "^6.9.0",
     "eslint-plugin-babel": "^5.3.0",

diff --git a/scripts/eslint-rules/__tests__/no-production-logging-test.internal.js b/scripts/eslint-rules/__tests__/no-production-logging-test.internal.js
@@ -110,7 +110,6 @@ ruleTester.run('no-production-logging', rule, {
   invalid: [
     {
       code: "console.error('Oh no');",
-      output: "if (__DEV__) {console.error('Oh no')};",
       errors: [
         {
           message: `Wrap console.error() in an "if (__DEV__) {}" check`,
@@ -119,7 +118,6 @@ ruleTester.run('no-production-logging', rule, {
     },
     {
       code: "console.warn('Oh no');",
-      output: "if (__DEV__) {console.warn('Oh no')};",
       errors: [
         {
           message: `Wrap console.warn() in an "if (__DEV__) {}" check`,
@@ -128,7 +126,6 @@ ruleTester.run('no-production-logging', rule, {
     },
     {
       code: "console.warn('Oh no')",
-      output: "if (__DEV__) {console.warn('Oh no')}",
       errors: [
         {
           message: `Wrap console.warn() in an "if (__DEV__) {}" check`,
@@ -141,11 +138,6 @@ ruleTester.run('no-production-logging', rule, {
           console.warn('Oh no');
         }
       `,
-      output: `
-        if (potato) {
-          if (__DEV__) {console.warn('Oh no')};
-        }
-      `,
       errors: [
         {
           message: `Wrap console.warn() in an "if (__DEV__) {}" check`,
@@ -158,11 +150,6 @@ ruleTester.run('no-production-logging', rule, {
           console.error('Oh no');
         }
       `,
-      output: `
-        if (__DEV__ || potato && true) {
-          if (__DEV__) {console.error('Oh no')};
-        }
-      `,
       errors: [
         {
           message: `Wrap console.error() in an "if (__DEV__) {}" check`,
@@ -175,11 +162,6 @@ ruleTester.run('no-production-logging', rule, {
           console.error('Oh no');
         }
       `,
-      output: `
-        if (banana && __DEV__ && potato && kitten) {
-          if (__DEV__) {console.error('Oh no')};
-        }
-      `,
       // Technically this code is valid but we prefer
       // explicit standalone __DEV__ blocks that stand out.
       errors: [
@@ -194,11 +176,6 @@ ruleTester.run('no-production-logging', rule, {
           console.error('Oh no');
         }
       `,
-      output: `
-        if (!__DEV__) {
-          if (__DEV__) {console.error('Oh no')};
-        }
-      `,
       errors: [
         {
           message: `Wrap console.error() in an "if (__DEV__) {}" check`,
@@ -211,11 +188,6 @@ ruleTester.run('no-production-logging', rule, {
           console.error('Oh no');
         }
       `,
-      output: `
-        if (foo || x && __DEV__) {
-          if (__DEV__) {console.error('Oh no')};
-        }
-      `,
       errors: [
         {
           message: `Wrap console.error() in an "if (__DEV__) {}" check`,
@@ -229,12 +201,6 @@ ruleTester.run('no-production-logging', rule, {
           console.error('Oh no');
         }
       `,
-      output: `
-        if (__DEV__) {
-        } else {
-          if (__DEV__) {console.error('Oh no')};
-        }
-      `,
       errors: [
         {
           message: `Wrap console.error() in an "if (__DEV__) {}" check`,
@@ -251,15 +217,6 @@ ruleTester.run('no-production-logging', rule, {
           }
         }
       `,
-      output: `
-        if (__DEV__) {
-        } else {
-          if (__DEV__) {
-          } else {
-            if (__DEV__) {console.error('Oh no')};
-          }
-        }
-      `,
       errors: [
         {
           message: `Wrap console.error() in an "if (__DEV__) {}" check`,