Skip to content

Commit

Permalink
validateDOMNesting: Allow hr as child of select (#27632)
Browse files Browse the repository at this point in the history
fix #27572

---------

Co-authored-by: Sophie Alpert <[email protected]>

DiffTrain build for [ca16c26](ca16c26)
  • Loading branch information
sophiebits committed Oct 31, 2023
1 parent 21d5f5f commit 8c6e716
Show file tree
Hide file tree
Showing 6 changed files with 30 additions and 10 deletions.
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3e09c27b880e1fecdb1eca5db510ecce37ea6be2
ca16c26356221a4b52185d7425d77675f0307250
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -579,4 +579,4 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "18.3.0-www-modern-756318c7";
exports.version = "18.3.0-www-modern-d01608e2";
9 changes: 7 additions & 2 deletions compiled/facebook-www/ReactDOM-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -4784,7 +4784,12 @@ function isTagValidWithParent(tag, parentTag) {
switch (parentTag) {
// https://html.spec.whatwg.org/multipage/syntax.html#parsing-main-inselect
case "select":
return tag === "option" || tag === "optgroup" || tag === "#text";
return (
tag === "hr" ||
tag === "option" ||
tag === "optgroup" ||
tag === "#text"
);

case "optgroup":
return tag === "option" || tag === "#text";
Expand Down Expand Up @@ -34159,7 +34164,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-classic-7b8a9a9d";
var ReactVersion = "18.3.0-www-classic-e9edf038";

function createPortal$1(
children,
Expand Down
9 changes: 7 additions & 2 deletions compiled/facebook-www/ReactDOM-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -4606,7 +4606,12 @@ function isTagValidWithParent(tag, parentTag) {
switch (parentTag) {
// https://html.spec.whatwg.org/multipage/syntax.html#parsing-main-inselect
case "select":
return tag === "option" || tag === "optgroup" || tag === "#text";
return (
tag === "hr" ||
tag === "option" ||
tag === "optgroup" ||
tag === "#text"
);

case "optgroup":
return tag === "option" || tag === "#text";
Expand Down Expand Up @@ -34004,7 +34009,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-modern-dd65b169";
var ReactVersion = "18.3.0-www-modern-fb6585b7";

function createPortal$1(
children,
Expand Down
9 changes: 7 additions & 2 deletions compiled/facebook-www/ReactDOMTesting-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -4918,7 +4918,12 @@ function isTagValidWithParent(tag, parentTag) {
switch (parentTag) {
// https://html.spec.whatwg.org/multipage/syntax.html#parsing-main-inselect
case "select":
return tag === "option" || tag === "optgroup" || tag === "#text";
return (
tag === "hr" ||
tag === "option" ||
tag === "optgroup" ||
tag === "#text"
);

case "optgroup":
return tag === "option" || tag === "#text";
Expand Down Expand Up @@ -34776,7 +34781,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-classic-67744070";
var ReactVersion = "18.3.0-www-classic-91f20f7a";

function createPortal$1(
children,
Expand Down
9 changes: 7 additions & 2 deletions compiled/facebook-www/ReactDOMTesting-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -4740,7 +4740,12 @@ function isTagValidWithParent(tag, parentTag) {
switch (parentTag) {
// https://html.spec.whatwg.org/multipage/syntax.html#parsing-main-inselect
case "select":
return tag === "option" || tag === "optgroup" || tag === "#text";
return (
tag === "hr" ||
tag === "option" ||
tag === "optgroup" ||
tag === "#text"
);

case "optgroup":
return tag === "option" || tag === "#text";
Expand Down Expand Up @@ -34621,7 +34626,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-modern-756318c7";
var ReactVersion = "18.3.0-www-modern-d01608e2";

function createPortal$1(
children,
Expand Down

0 comments on commit 8c6e716

Please sign in to comment.