-
Notifications
You must be signed in to change notification settings - Fork 47.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validateDOMNesting: Allow hr as child of select #27632
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comparing: 0c63487...9ef29fb Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
@sophiebits, @SouSingh got to this before I did :) (re: #27572) |
sophiebits
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
sophiebits
changed the title
Update validateDOMNesting.js
validateDOMNesting: Allow hr as child of select
Oct 31, 2023
sophiebits
reviewed
Oct 31, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Oct 31, 2023
fix #27572 --------- Co-authored-by: Sophie Alpert <[email protected]> DiffTrain build for [ca16c26](ca16c26)
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Nov 1, 2023
Updates React from 0c6348758 to 08a39539f. ### React upstream changes - facebook/react#27634 - facebook/react#27632
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
fix facebook#27572 --------- Co-authored-by: Sophie Alpert <[email protected]>
bigfootjon
pushed a commit
that referenced
this pull request
Apr 18, 2024
fix #27572 --------- Co-authored-by: Sophie Alpert <[email protected]> DiffTrain build for commit ca16c26.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #27572