Skip to content

Commit

Permalink
[Float][Fiber] Fixes incorrect boolean logic around loading states fo…
Browse files Browse the repository at this point in the history
…r stylesheets (#27610)

the loading states of stylesheets found in the DOM during preinit should
be assumed to be loaded

DiffTrain build for [3e09c27](3e09c27)
  • Loading branch information
gnoff committed Oct 27, 2023
1 parent 9bdb530 commit 21d5f5f
Show file tree
Hide file tree
Showing 14 changed files with 36 additions and 36 deletions.
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
8c8ee9ee618eace9199b7c80f4cd2d6f20ecfb73
3e09c27b880e1fecdb1eca5db510ecce37ea6be2
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ if (
}
"use strict";

var ReactVersion = "18.3.0-www-classic-8d8af9ad";
var ReactVersion = "18.3.0-www-classic-cdb80134";

// ATTENTION
// When adding new symbols to this file,
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -579,4 +579,4 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "18.3.0-www-modern-e84915a0";
exports.version = "18.3.0-www-modern-756318c7";
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-profiling.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -590,7 +590,7 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "18.3.0-www-modern-8b229aeb";
exports.version = "18.3.0-www-modern-a47fcd28";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
4 changes: 2 additions & 2 deletions compiled/facebook-www/ReactDOM-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -34159,7 +34159,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-classic-c09aff01";
var ReactVersion = "18.3.0-www-classic-7b8a9a9d";

function createPortal$1(
children,
Expand Down Expand Up @@ -43312,7 +43312,7 @@ function preinitStyle(href, precedence, options) {
);

if (instance) {
state.loading = Loaded & Inserted;
state.loading = Loaded | Inserted;
} else {
// Construct a new instance and insert it
var stylesheetProps = assign(
Expand Down
4 changes: 2 additions & 2 deletions compiled/facebook-www/ReactDOM-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -34004,7 +34004,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-modern-7aff7d5d";
var ReactVersion = "18.3.0-www-modern-dd65b169";

function createPortal$1(
children,
Expand Down Expand Up @@ -43822,7 +43822,7 @@ function preinitStyle(href, precedence, options) {
);

if (instance) {
state.loading = Loaded & Inserted;
state.loading = Loaded | Inserted;
} else {
// Construct a new instance and insert it
var stylesheetProps = assign(
Expand Down
8 changes: 4 additions & 4 deletions compiled/facebook-www/ReactDOM-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -15149,7 +15149,7 @@ function preinitStyle(href, precedence, options) {
getStylesheetSelectorFromKey(key)
))
)
state.loading = 0;
state.loading = 5;
else {
href = assign(
{ rel: "stylesheet", href: href, "data-precedence": precedence },
Expand Down Expand Up @@ -16485,7 +16485,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1796 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-classic-372e3020",
version: "18.3.0-www-classic-fba9e8d0",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2142 = {
Expand Down Expand Up @@ -16515,7 +16515,7 @@ var internals$jscomp$inline_2142 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-www-classic-372e3020"
reconcilerVersion: "18.3.0-www-classic-fba9e8d0"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2143 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -16852,4 +16852,4 @@ exports.useFormState = function () {
exports.useFormStatus = function () {
throw Error(formatProdErrorMessage(248));
};
exports.version = "18.3.0-www-classic-372e3020";
exports.version = "18.3.0-www-classic-fba9e8d0";
8 changes: 4 additions & 4 deletions compiled/facebook-www/ReactDOM-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -15378,7 +15378,7 @@ function preinitStyle(href, precedence, options) {
getStylesheetSelectorFromKey(key)
))
)
state.loading = 0;
state.loading = 5;
else {
href = assign(
{ rel: "stylesheet", href: href, "data-precedence": precedence },
Expand Down Expand Up @@ -16011,7 +16011,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1755 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-modern-4b17b85c",
version: "18.3.0-www-modern-ecf7ebc4",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2106 = {
Expand Down Expand Up @@ -16042,7 +16042,7 @@ var internals$jscomp$inline_2106 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-www-modern-4b17b85c"
reconcilerVersion: "18.3.0-www-modern-ecf7ebc4"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2107 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -16307,4 +16307,4 @@ exports.useFormState = function () {
exports.useFormStatus = function () {
throw Error(formatProdErrorMessage(248));
};
exports.version = "18.3.0-www-modern-4b17b85c";
exports.version = "18.3.0-www-modern-ecf7ebc4";
8 changes: 4 additions & 4 deletions compiled/facebook-www/ReactDOM-profiling.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -15925,7 +15925,7 @@ function preinitStyle(href, precedence, options) {
getStylesheetSelectorFromKey(key)
))
)
state.loading = 0;
state.loading = 5;
else {
href = assign(
{ rel: "stylesheet", href: href, "data-precedence": precedence },
Expand Down Expand Up @@ -17261,7 +17261,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1881 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-classic-a0476b39",
version: "18.3.0-www-classic-7b8abb91",
rendererPackageName: "react-dom"
};
(function (internals) {
Expand Down Expand Up @@ -17305,7 +17305,7 @@ var devToolsConfig$jscomp$inline_1881 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-www-classic-a0476b39"
reconcilerVersion: "18.3.0-www-classic-7b8abb91"
});
assign(Internals, {
ReactBrowserEventEmitter: {
Expand Down Expand Up @@ -17629,7 +17629,7 @@ exports.useFormState = function () {
exports.useFormStatus = function () {
throw Error(formatProdErrorMessage(248));
};
exports.version = "18.3.0-www-classic-a0476b39";
exports.version = "18.3.0-www-classic-7b8abb91";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
8 changes: 4 additions & 4 deletions compiled/facebook-www/ReactDOM-profiling.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -16148,7 +16148,7 @@ function preinitStyle(href, precedence, options) {
getStylesheetSelectorFromKey(key)
))
)
state.loading = 0;
state.loading = 5;
else {
href = assign(
{ rel: "stylesheet", href: href, "data-precedence": precedence },
Expand Down Expand Up @@ -16781,7 +16781,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1840 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-modern-c2da1a8c",
version: "18.3.0-www-modern-327d25fe",
rendererPackageName: "react-dom"
};
(function (internals) {
Expand Down Expand Up @@ -16826,7 +16826,7 @@ var devToolsConfig$jscomp$inline_1840 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-www-modern-c2da1a8c"
reconcilerVersion: "18.3.0-www-modern-327d25fe"
});
exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = Internals;
exports.createPortal = function (children, container) {
Expand Down Expand Up @@ -17078,7 +17078,7 @@ exports.useFormState = function () {
exports.useFormStatus = function () {
throw Error(formatProdErrorMessage(248));
};
exports.version = "18.3.0-www-modern-c2da1a8c";
exports.version = "18.3.0-www-modern-327d25fe";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
4 changes: 2 additions & 2 deletions compiled/facebook-www/ReactDOMTesting-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -34776,7 +34776,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-classic-aab000c9";
var ReactVersion = "18.3.0-www-classic-67744070";

function createPortal$1(
children,
Expand Down Expand Up @@ -44061,7 +44061,7 @@ function preinitStyle(href, precedence, options) {
);

if (instance) {
state.loading = Loaded & Inserted;
state.loading = Loaded | Inserted;
} else {
// Construct a new instance and insert it
var stylesheetProps = assign(
Expand Down
4 changes: 2 additions & 2 deletions compiled/facebook-www/ReactDOMTesting-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -34621,7 +34621,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-modern-e84915a0";
var ReactVersion = "18.3.0-www-modern-756318c7";

function createPortal$1(
children,
Expand Down Expand Up @@ -44571,7 +44571,7 @@ function preinitStyle(href, precedence, options) {
);

if (instance) {
state.loading = Loaded & Inserted;
state.loading = Loaded | Inserted;
} else {
// Construct a new instance and insert it
var stylesheetProps = assign(
Expand Down
8 changes: 4 additions & 4 deletions compiled/facebook-www/ReactDOMTesting-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -15478,7 +15478,7 @@ function preinitStyle(href, precedence, options) {
getStylesheetSelectorFromKey(key)
))
)
state.loading = 0;
state.loading = 5;
else {
href = assign(
{ rel: "stylesheet", href: href, "data-precedence": precedence },
Expand Down Expand Up @@ -16814,7 +16814,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1825 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-classic-8d8af9ad",
version: "18.3.0-www-classic-cdb80134",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2176 = {
Expand Down Expand Up @@ -16844,7 +16844,7 @@ var internals$jscomp$inline_2176 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-www-classic-8d8af9ad"
reconcilerVersion: "18.3.0-www-classic-cdb80134"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2177 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -17332,4 +17332,4 @@ exports.useFormState = function () {
exports.useFormStatus = function () {
throw Error(formatProdErrorMessage(248));
};
exports.version = "18.3.0-www-classic-8d8af9ad";
exports.version = "18.3.0-www-classic-cdb80134";
8 changes: 4 additions & 4 deletions compiled/facebook-www/ReactDOMTesting-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -15758,7 +15758,7 @@ function preinitStyle(href, precedence, options) {
getStylesheetSelectorFromKey(key)
))
)
state.loading = 0;
state.loading = 5;
else {
href = assign(
{ rel: "stylesheet", href: href, "data-precedence": precedence },
Expand Down Expand Up @@ -16391,7 +16391,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1784 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-modern-8b229aeb",
version: "18.3.0-www-modern-a47fcd28",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2140 = {
Expand Down Expand Up @@ -16422,7 +16422,7 @@ var internals$jscomp$inline_2140 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-www-modern-8b229aeb"
reconcilerVersion: "18.3.0-www-modern-a47fcd28"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2141 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -16838,4 +16838,4 @@ exports.useFormState = function () {
exports.useFormStatus = function () {
throw Error(formatProdErrorMessage(248));
};
exports.version = "18.3.0-www-modern-8b229aeb";
exports.version = "18.3.0-www-modern-a47fcd28";

0 comments on commit 21d5f5f

Please sign in to comment.