Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.48] Commits to cherry-pick into stable release #15318

Closed
grabbou opened this issue Aug 1, 2017 · 31 comments
Closed

[0.48] Commits to cherry-pick into stable release #15318

grabbou opened this issue Aug 1, 2017 · 31 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@grabbou
Copy link
Contributor

grabbou commented Aug 1, 2017

No description provided.

@iegik
Copy link

iegik commented Aug 4, 2017

Broken commit: 712b1dd

node_modules/react-native/Libraries/NativeAnimation/RCTNativeAnimatedModule.h:14:9: 'React/RCTUIManagerObserverCoordinator.h' file not found

    "react": "^16.0.0-alpha.12",
    "react-native": "0.47.1",

@iegik
Copy link

iegik commented Aug 4, 2017 

node_modules/react-native/Libraries/Text/RCTTextFieldManager.m:14:9: 'React/RCTShadowView+Layout.h' file not found

@grabbou
Copy link
Contributor Author

grabbou commented Aug 7, 2017

@iegik you sure about that one? In order to release a beta, I had to compile it. That looks like a compile-time issue that I didn't encounter. Have you managed to resolve it in the meantime?

@iegik
Copy link

iegik commented Aug 8, 2017

Checkout also #15365 (comment)

@iegik
Copy link

iegik commented Aug 8, 2017

I'm definitely not sure about that, but then I try to build the application, i felt in a lot of errors. Tried to clean, install again and again. No luck.

@lprhodes
Copy link
Contributor

I'd like to nominate cb1b1e5 as it fixes something I previously broke

@willdawsonme
Copy link

willdawsonme commented Aug 11, 2017 •
edited
Loading

c9aeaf6 would be great to get in if possible.

shergin referenced this issue Aug 11, 2017
@shergin @facebook-github-bot
TextInput: Refined contentSize calculation
603cc48 
Summary: This fixes pretty bad issue when contentSize is calculated based on an intrinsic horizontal (width) limitation, not on a real/current horizontal (width) one.

Reviewed By: mmmulani

Differential Revision: D5422114

fbshipit-source-id: 0eb582aeb59d29530990d4faabf2f41baa79c058
@eliperkins
Copy link
Contributor

eliperkins commented Aug 11, 2017 •
edited
Loading

I'd like to nominate 603cc48ceba001827d10231d51b4031c7768eef8, as described in this comment: 603cc48#commitcomment-23539206

I think this needs to get cherry picked into 0.47.0-stable to fix issues like #15326. Otherwise, multiline autoexpanding TextInputs will always return the same height for their content.

@ajostergaard
Copy link

While not exactly critical would be really nice to get HMR to work across all connected clients simultaneously - I believe 8b2975a sorts this out. Nice incremental improvement to everybody's workflow. :)

@grabbou
Copy link
Contributor Author

grabbou commented Aug 16, 2017

@eliperkins 603cc48 is already in the rc version. I have cherry-picked the rest and sent out a new build to Circle.

@ajostergaard I am going to wait with the HMR one for few more days to let it settle in the master branch.

@eliperkins
Copy link
Contributor

@grabbou Ah! My mistake, I meant 603cc48 into 0.47.0, not 0.48.0. 😬

Due to the changes made in a8c45ac, content size on TextInput is currently broken, without cherry-picking 603cc48. This seems like a pretty serious regression that deserves a patch, especially since we know how to fix it, and the fix is in the next monthly release as well.

Are patches still being made to 0.47.0? I didn't see another issue similar to this one for 0.47.0. I can open another ticket and nominate that cherry-pick if you'd like to keep the chatter out of this one.

@ide
Copy link
Contributor

ide commented Aug 16, 2017

Here's the current status of things:

The HMR fix is sitting in master and either way it will go out with 0.49.0-rc.0.

The rest of the discussions looked unrelated to cherry picks for 0.48.

@grabbou
Copy link
Contributor Author

grabbou commented Aug 17, 2017

Thanks @ide for the summary! @eliperkins in order to suggest a patch to 0.47, please post in #14840

@eliperkins eliperkins mentioned this issue Aug 17, 2017
Closed
@Emilios1995
Copy link
Contributor

Emilios1995 commented Aug 30, 2017 •
edited by shergin
Loading

Hi, maintainers!
Would it be possible to include flow 0.53 in the next release?
(commit 90eaeb0)

@grabbou
Copy link
Contributor Author

grabbou commented Sep 1, 2017

I am not really sure it's needed. Cherry-picks are meant to be used when we fix issues that got fixed in master in the meantime. Features and improvements can usually wait for the next release (0.49). For historical reasons, I am against importing anything related to flow as it touches many files across the project and has high potential of breaking.

Anyways, for now I am closing this as release is being promoted to stable.

@grabbou grabbou closed this as completed Sep 1, 2017
@fungilation
Copy link

Where's the 0.48 changelog?

@grabbou
Copy link
Contributor Author

grabbou commented Sep 2, 2017 via email

@grabbou
Copy link
Contributor Author

grabbou commented Sep 4, 2017

One of the commits by @janicduplessis was reverted as it caused iOS to crash. Fix has been submitted and is already in 0.49 - we need to cherry-pick that one later this week.

@ide
Copy link
Contributor

ide commented Sep 7, 2017 •
edited
Loading

Adding an Android scroll view fix (e964a7f) and iOS font fix (d3007b0) to 0.48-stable and releasing as 0.48.2. The files that both commits touch haven't had any other changes to them since 0.48-stable.

Also cherry-picking these into 0.49-stable so that we don't regress from 0.48 to 0.49 and am releasing an 0.49 RC (will cross-post in the 0.49 cherry-pick issue so we don't miss this).

@ide
Copy link
Contributor

ide commented Sep 11, 2017 •
edited
Loading

Cherry-picked two bridge-related fixes for reloading C++ bridge (1f9fc0e and 7b77055). CI is publishing 0.48.3.

@fungilation
Copy link

https://github.com/facebook/react-native/releases/tag/v0.48.3 is up but not on npm? At least not to yarn outdated

@grabbou
Copy link
Contributor Author

grabbou commented Sep 12, 2017

0.48.3 build has finished, please double check. Chances are you might have been looking before it finished.

@fungilation
Copy link

Ya I guess it took an hour or so for npm to pick up the new release? But it came on yarn, thanks

@ide
Copy link
Contributor

ide commented Sep 19, 2017

Cherry-picked a fix for Jest tests into 0.48.4:

  • Add BlobModule native module mock to jest setup: 165f876

@grabbou
Copy link
Contributor Author

grabbou commented Sep 21, 2017

I have scheduled the build once again. I believe it should land on npm this time.

@fungilation
Copy link

Nope, still nothing.

Shouldn't this sort of thing be scripted?

@ide
Copy link
Contributor

ide commented Sep 21, 2017

It is scripted but the CI pipeline failed.

@fungilation
Copy link

And still failing. Not on npm

@fungilation
Copy link

Any update on when the releases train for bug fixes will be fixed?

@grabbou
Copy link
Contributor Author

grabbou commented Sep 23, 2017 via email

@fungilation
Copy link

Looks like it's fixed? 0.48.4 was on npm

@eliperkins eliperkins mentioned this issue Mar 21, 2018
Closed
2 tasks
@facebook facebook locked as resolved and limited conversation to collaborators Sep 1, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Sep 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@lprhodes @iegik @ide @ajostergaard @eliperkins @grabbou @fungilation @willdawsonme @Emilios1995 @react-native-bot