Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.54.0 cherry-pick issue has been locked, preventing community from helping maintain #18489

Closed
2 tasks done
eliperkins opened this issue Mar 21, 2018 · 5 comments
Closed
2 tasks done
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@eliperkins
Copy link
Contributor

My company uses React Native for our mobile app and has been working to give back to the React Native community by identifying fixes and adopting the latest version of React Native to help identify issues in the latest releases.

Last week, we identified a regression in the <Text> component, and found that an issue had already been filed for it: #18258. Not only that, but @shergin had also identified a fix, and committed it to master: a534672

It's my understanding that these issues should be used to track what cherry-picks should happen to fix bugs in each release. In fact, I've been instructed by maintainers to advocate for cherry-picks in the past before.

However, upon proposing that a commit be cherry-picked into the latest release this time, the issue was promptly closed. I was left feeling like my feedback was not wanted, even though I had spent the time to thoroughly investigate the issue, and bring a well-formulated issue to light. I understand that React Native receives a lot of poorly-formulated issues that do not provide enough information for the maintainers of this repo to act upon, yet I feel that my comment was warranted as it clearly identified a fix.

Is this not the appropriate process to sifting through the sea of GitHub issues and identifying fixes, to help better maintain this project? If not, what is the right way to help maintain React Native, as a well-intentioned user of the framework?

Thanks for listening.

Steps to Reproduce

  1. Find a regression in a React Native release
  2. Identify a fix has landed in the next release
  3. Identify that the fix would be backwards compatible with current release that has the regression
  4. Propose that the fix gets cherry-picked into the current release to fix the regression

Expected Behavior

The fix gets cherry-picked by a maintainer in the latest release to fix the regression.

Actual Behavior

Issue to keep track of cherry-pick proposals is marked as "off-topic" and is locked by a maintainer.
#18128 (comment)
screen shot 2018-03-21 at 9 47 03 am

@hramos
Copy link
Contributor

hramos commented Mar 21, 2018

The last comment in the thread contains the actual location where we track cherry-pick requests, hence why it was closed and locked.

screen shot 2018-03-21 at 10 46 20 am

@hramos hramos closed this as completed Mar 21, 2018
@eliperkins
Copy link
Contributor Author

@hramos so should we propose cherry-picks to that issue instead? That's still unclear to me...

@hramos
Copy link
Contributor

hramos commented Mar 21, 2018

Yes. @grabbou coordinates releases and was the original advocate for tracking cherry-pick requests in issues in this repo. He has now created a new repo, react-native-releases, specifically for this purpose. Going forward, use that repo for cherry-pick requests. There should be an issue for each upcoming release. This will help keep the core repo clear of non-bug report issues.

@grabbou
Copy link
Contributor

grabbou commented Mar 21, 2018

@eliperkins we are still working on this and will put some wiki notes to the repository itself later today/tomorrow. The main reason for having a separate repo for cherry picks/issue reports is to avoid anyone from the release team omitting an important bug due to other, non-release related notifications. I, myself, get hundreds of them and it takes a while to get on top of them all.

@grabbou
Copy link
Contributor

grabbou commented Mar 21, 2018

Meanwhile, please carry on the discussion here: react-native-community/releases#10

@facebook facebook locked as resolved and limited conversation to collaborators Mar 21, 2019
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Mar 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

4 participants