Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.54] Commits to cherry-pick into stable release #18128

Closed
hramos opened this issue Feb 27, 2018 · 15 comments
Closed

[0.54] Commits to cherry-pick into stable release #18128

hramos opened this issue Feb 27, 2018 · 15 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@hramos
Copy link
Contributor

hramos commented Feb 27, 2018

The thread containing issues that are blocking the 0.54 release and need to be addressed.

Please keep this list to critical bug fixes that are new in 0.54 and ideally have been merged into master -- post commit hashes rather than issue/PR numbers unless the issue/PR in question targets a problem specific to 0.54. The intent of these cherry-pick threads is not to solicit features but to fix things that make 0.54 substantially more launch-blocked than 0.53.

@hramos
Copy link
Contributor Author

hramos commented Feb 27, 2018

  • b60a727 has been proposed by @joshyhargreaves

@grabbou
Copy link
Contributor

grabbou commented Mar 1, 2018

Closing as the release is hitting npm soon. Hector, thank you for opening the issue.

@grabbou grabbou closed this as completed Mar 1, 2018
@fungilation
Copy link

Changelog still missing? https://github.com/facebook/react-native/releases

@hramos
Copy link
Contributor Author

hramos commented Mar 3, 2018

See https://twitter.com/grabbou/status/969284993859117056 -- it's coming

@fungilation
Copy link

"Draft complete; needs review" now, but still missing on where it matters publicly

@grabbou
Copy link
Contributor

grabbou commented Mar 5, 2018

Will be up in 2 hours.

@grabbou
Copy link
Contributor

grabbou commented Mar 5, 2018

I've also updated the release description to contain our current draft before I make it public. We are at the final step reviewing last commits.

For the next release, I'll make sure to update the release description a bit earlier and also, do a Twitter announcement from our account (React Native)

@fungilation
Copy link

7be3d1c to fix #18209 (comment)

@grabbou
Copy link
Contributor

grabbou commented Mar 15, 2018

Cherry-picked

@andrew-wagner89
Copy link

b02b167 to fix #18179

@almostintuitive
Copy link

almostintuitive commented Mar 18, 2018

A new patch version would be much appreciated!
It'd fix: #18179 which is currently blocking quite a few people from using 0.54

@grabbou
Copy link
Contributor

grabbou commented Mar 19, 2018 via email

@eliperkins
Copy link
Contributor

a534672 to fix #18258 since it's a regression

@grabbou
Copy link
Contributor

grabbou commented Mar 20, 2018

I am waiting for one more fix to hit master and will chery-pick them all. Please follow the status here: react-native-community/releases#8

@facebook facebook locked as off-topic and limited conversation to collaborators Mar 20, 2018
@grabbou
Copy link
Contributor

grabbou commented Mar 21, 2018

Please report any additional requests / issues with this release over here: react-native-community/releases#10

@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Mar 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

7 participants