Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix? #15365

Closed
wants to merge 1 commit into from
Closed

fix? #15365

wants to merge 1 commit into from

Conversation

iegik
Copy link

@iegik iegik commented Aug 4, 2017

While debugging in XCode, I fixed that. I do not know exactly what am I doing. Please, check.

    "react": "^16.0.0-alpha.12",
    "react-native": "0.47.1",
node_modules/react-native/Libraries/Text/RCTTextInput.m:68:38: Property 'reactCompoundInsets' not found on object of type 'RCTTextInput *'

node_modules/react-native/Libraries/Text/RCTTextInput.m:145:29: No visible @interface for 'UIView<RCTBackedTextInputViewProtocol>' declares the selector 'reactFocus'

node_modules/react-native/Libraries/Text/RCTTextInput.m:150:29: No visible @interface for 'UIView<RCTBackedTextInputViewProtocol>' declares the selector 'reactBlur'

node_modules/react-native/Libraries/Text/RCTTextInput.m:155:29: No visible @interface for 'UIView<RCTBackedTextInputViewProtocol>' declares the selector 'reactFocusIfNeeded'

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@hramos
Copy link
Contributor

hramos commented Aug 4, 2017

Hey! Thanks for working on this. One thing I would recommend is to update your PR to explain what problem you ran into, and how you tested that this fixed the issue. You can see more about writing a test plan in our contribution guidelines. Thanks!

@shergin shergin self-requested a review August 6, 2017 04:30
@shergin
Copy link
Contributor

shergin commented Aug 6, 2017

UIEdgeInsetsInsetRect is a function. Using it as a type makes no sense.
Which problem are you trying to solve?

@shergin shergin closed this Aug 6, 2017
@iegik
Copy link
Author

iegik commented Aug 8, 2017

I`ve got several errors while building the project. I wrote these errors in description. I don't know how to fix them right. RN just fail to build.

@shergin
Copy link
Contributor

shergin commented Aug 8, 2017

@iegik Looks like your Xcode project file is outdated and did not contain new files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants