Fix #1512: Plugin doesn't abort building an image in case Podman is u…

[jh-cd]

Fix #1512

In the previous version of this file the following if() was as follows. The methode isJson() checks by header (not by body):

     if(isJson(response)) {
          EntityStreamReaderUtil.processJsonStream(handler, stream);
     }

In case the Podman daemon is used, the POST /build response is JSON and the HTTP status code is 200
as expected, but there is no header "Content-Type = application/json" nor "Content-Type" at all. Seen in
Podman 3.4.2. But the docker-maven-plugin relies on that JSON-body. In BuildJsonResponseHandler.process():

     if (json.has("error")) {
    ...
    throw new DockerAccessException();

If no error is detected, the Maven-build goes on despite there was a problem building the
image!
The following if() first checks for the application/json Content-Type. If no Content-Type is set,
it tries to detect if the body is JSON. If so, the handler is called.

[codecov]

Codecov Report

Merging #1585 (88b2da5) into master (df4d7d0) will increase coverage by 0.03%.
The diff coverage is 85.00%.

@@             Coverage Diff              @@
##             master    #1585      +/-   ##
============================================
+ Coverage     63.51%   63.54%   +0.03%     
- Complexity     2163     2169       +6     
============================================
  Files           170      170              
  Lines          9905     9923      +18     
  Branches       1359     1360       +1     
============================================
+ Hits           6291     6306      +15     
- Misses         3085     3087       +2     
- Partials        529      530       +1     

Impacted Files	Coverage Δ
...ker/access/hc/HcChunkedResponseHandlerWrapper.java	82.75% <85.00%> (+0.94%)	⬆️

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

89.3% Coverage
0.0% Duplication

[manusa]

Relates to:

• fix: Support for Podman REST API (when configured) #1404
• fix: Docker push works with Podman REST API eclipse-jkube/jkube#451

[manusa]

Logic seems fine.

Maybe you'd want to introduce a complete test case with JSON response that verifies the scenario described by the issue.