Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support for Podman REST API (when configured) #1404

Merged

Conversation

manusa
Copy link
Member

@manusa manusa commented Nov 13, 2020

  • fix: Valid content type for REST docker-compatible API requests with body
  • fix: Push works with Podman REST API

This PR ports work done on eclipse-jkube/jkube#442 and eclipse-jkube/jkube#451 which allow the usage of Podman's REST API preventing the problems exposed in this comment.

This video (using JKube instead) showcases how you would run JKube>DMP once the fix is merged: https://www.youtube.com/watch?v=hsomx014VPE

Relates to: #1330 eclipse-jkube/jkube#66

Most of the manual configuration can be now be avoided if using podman-docker package (yum -y install podman-docker) and enabling the podman.socket service (systemctl enable --now podman.socket)

@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #1404 (7a6dbb9) into master (1244718) will increase coverage by 0.38%.
The diff coverage is 84.21%.

@@             Coverage Diff              @@
##             master    #1404      +/-   ##
============================================
+ Coverage     57.69%   58.08%   +0.38%     
- Complexity     1916     1939      +23     
============================================
  Files           161      162       +1     
  Lines          9006     9013       +7     
  Branches       1359     1361       +2     
============================================
+ Hits           5196     5235      +39     
+ Misses         3335     3300      -35     
- Partials        475      478       +3     
Impacted Files Coverage Δ Complexity Δ
...ven/docker/access/hc/DockerAccessWithHcClient.java 25.21% <ø> (-0.35%) 26.00 <0.00> (ø)
...ker/access/hc/HcChunkedResponseHandlerWrapper.java 81.81% <81.81%> (ø) 6.00 <6.00> (?)
...ven/docker/access/hc/ApacheHttpClientDelegate.java 57.97% <87.50%> (+47.36%) 17.00 <2.00> (+17.00)

@manusa manusa force-pushed the fix/podman-rest-improvements branch from 5daa962 to 06cdd90 Compare November 13, 2020 11:47
@rohanKanojia rohanKanojia requested a review from rhuss November 13, 2020 12:43
- fix: Valid content type for REST docker-compatible API requests with body
- fix: Push works with Podman REST API
@manusa manusa force-pushed the fix/podman-rest-improvements branch from 06cdd90 to e52ee35 Compare December 3, 2020 13:24
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 3, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

86.7% 86.7% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants