Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin doesn't abort building an image in case Podman is used and the Dockerfile can't be processed #1684

Closed
manusa opened this issue Aug 1, 2022 · 1 comment · Fixed by #1882
Closed

Plugin doesn't abort building an image in case Podman is used and the Dockerfile can't be processed #1684

manusa opened this issue Aug 1, 2022 · 1 comment · Fixed by #1882
Assignees
@sunix
Labels
bug Something isn't working
Milestone
1.10.0

Comments

@manusa
Copy link
Member

manusa commented Aug 1, 2022 •
edited
Loading

Mirror of fabric8io/docker-maven-plugin#1512

Consider JSON responses from Docker/Podman HTTP API even if a Content-Type header is not provided in the HTTP response.
@manusa manusa added the bug Something isn't working label Aug 1, 2022
@manusa
Copy link
Member Author

manusa commented Aug 1, 2022

Fix should be inspired by fabric8io/docker-maven-plugin#1585 but implemented differently.

Also, proper tests are needed.

@manusa manusa added this to the 1.x milestone Aug 9, 2022
@manusa manusa moved this to Planned in Eclipse JKube Aug 10, 2022
@sunix sunix moved this from Planned to In Progress in Eclipse JKube Oct 3, 2022
@sunix sunix self-assigned this Oct 3, 2022
@sunix sunix moved this from In Progress to Review in Eclipse JKube Oct 26, 2022
@sunix sunix mentioned this issue Oct 26, 2022
Merged
17 tasks
@manusa manusa modified the milestones: 1.x, 1.10.0 Nov 2, 2022
Repository owner moved this from Review to Done in Eclipse JKube Nov 4, 2022
@rohanKanojia rohanKanojia mentioned this issue Jul 26, 2023
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sunix sunix

Labels
bug Something isn't working
Projects
None yet
Milestone
1.10.0
Development

Successfully merging a pull request may close this issue.

fix(docker-build): failing container build with Podman should fail properly sunix/jkube
2 participants
@manusa @sunix