Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a simple command API #1680

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Conversation

mwestphal
Copy link
Contributor

@mwestphal mwestphal commented Oct 27, 2024

  • Add a interactor::command API
  • Add the following commands:
    • set
    • toggle
    • reset
    • unset
    • print
    • many specific commands
  • Add dedicated documentation
  • Add python bindings and tests
  • Fix Incorrect behavior with the orthographic keybind #1685
  • Change options::toggle behavior with optional bool
  • Add tests
  • Add triggerCommand binding for java and wasm

Needed for:

Other things to do:

Copy link

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: python, java, webassembly.

Copy link

codecov bot commented Oct 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.98%. Comparing base (cdcb2cd) to head (9821d8b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1680      +/-   ##
==========================================
+ Coverage   96.95%   96.98%   +0.02%     
==========================================
  Files         106      106              
  Lines        8616     8781     +165     
==========================================
+ Hits         8354     8516     +162     
- Misses        262      265       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwestphal mwestphal force-pushed the add_command_api branch 2 times, most recently from 718ed20 to 31421d7 Compare November 2, 2024 17:01
@mwestphal mwestphal changed the title [draft] Add a simple command API Add a simple command API Nov 2, 2024
@mwestphal mwestphal requested review from snoyer and Meakk and removed request for snoyer November 2, 2024 21:17
application/F3DStarter.cxx Outdated Show resolved Hide resolved
application/F3DStarter.cxx Outdated Show resolved Hide resolved
application/F3DStarter.cxx Outdated Show resolved Hide resolved
application/F3DStarter.cxx Show resolved Hide resolved
doc/libf3d/OPTIONS.md Outdated Show resolved Hide resolved
doc/user/COMMANDS.md Outdated Show resolved Hide resolved
doc/user/COMMANDS.md Outdated Show resolved Hide resolved
library/private/interactor_impl.h Show resolved Hide resolved
library/src/interactor_impl.cxx Show resolved Hide resolved
library/src/interactor_impl.cxx Outdated Show resolved Hide resolved
library/src/interactor_impl.cxx Outdated Show resolved Hide resolved
library/src/interactor_impl.cxx Outdated Show resolved Hide resolved
library/src/interactor_impl.cxx Show resolved Hide resolved
@mwestphal mwestphal requested review from snoyer and Meakk November 4, 2024 18:06
library/src/interactor_impl.cxx Outdated Show resolved Hide resolved
library/src/interactor_impl.cxx Outdated Show resolved Hide resolved
library/src/interactor_impl.cxx Outdated Show resolved Hide resolved
library/src/interactor_impl.cxx Show resolved Hide resolved
library/src/interactor_impl.cxx Outdated Show resolved Hide resolved
library/src/interactor_impl.cxx Outdated Show resolved Hide resolved
library/src/interactor_impl.cxx Outdated Show resolved Hide resolved
@mwestphal mwestphal requested a review from Meakk November 5, 2024 16:08
doc/user/COMMANDS.md Outdated Show resolved Hide resolved
doc/user/COMMANDS.md Outdated Show resolved Hide resolved
library/src/interactor_impl.cxx Outdated Show resolved Hide resolved
library/src/interactor_impl.cxx Outdated Show resolved Hide resolved
python/F3DPythonBindings.cxx Show resolved Hide resolved
@mwestphal mwestphal force-pushed the add_command_api branch 2 times, most recently from 58ad394 to 939c20a Compare November 7, 2024 18:13
@mwestphal mwestphal requested a review from Meakk November 7, 2024 18:22
@mwestphal mwestphal force-pushed the add_command_api branch 3 times, most recently from f6f3fc0 to fad1a46 Compare November 7, 2024 18:31
@mwestphal mwestphal merged commit 15d0b19 into f3d-app:master Nov 7, 2024
40 checks passed
Yogesh9000 pushed a commit to Yogesh9000/f3d that referenced this pull request Nov 15, 2024
 - Add a interactor::command API
 - Add the following commands:
   - set
   - toggle
   - reset
   - unset
   - print
   -  many specific commands
 - Add dedicated documentation
 - Add python bindings and tests
 - Fix f3d-app#1685
 - Change options::toggle behavior with optional bool
 - Add tests
 - Add triggerCommand binding for java and wasm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect behavior with the orthographic keybind
3 participants