Skip to content

Commit

Permalink
baselines and strcit build
Browse files Browse the repository at this point in the history
  • Loading branch information
mwestphal committed Nov 2, 2024
1 parent 84be36c commit 31421d7
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 20 deletions.
11 changes: 1 addition & 10 deletions library/src/interactor_impl.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -176,13 +176,6 @@ class interactor_impl::internals
return;
}

// No user defined behavior, use standard behavior
vtkRenderWindow* renWin = self->Window.GetRenderWindow();
vtkF3DRenderer* ren = vtkF3DRenderer::SafeDownCast(renWin->GetRenderers()->GetFirstRenderer());
bool checkColoring = false;
bool printColoring = false;
bool render = false;

// Available keycodes: None
switch (keyCode)
{
Expand Down Expand Up @@ -486,7 +479,7 @@ class interactor_impl::internals
options& Options;
window_impl& Window;
scene_impl& Scene;
interactor_impl& Interactor; // TODO remove
interactor_impl& Interactor;
animationManager* AnimationManager;

vtkSmartPointer<vtkRenderWindowInteractor> VTKInteractor;
Expand Down Expand Up @@ -648,7 +641,6 @@ interactor_impl::interactor_impl(options& options, window_impl& window, scene_im
{
if (this->Internals->Options.scene.camera.orthographic.has_value())
{
// Cheatsheet not updating TODO
this->Internals->Options.scene.camera.orthographic = !this->Internals->Options.scene.camera.orthographic.value();
}
else
Expand All @@ -663,7 +655,6 @@ interactor_impl::interactor_impl(options& options, window_impl& window, scene_im
{
if (this->Internals->Options.render.show_edges.has_value())
{
// Cheatsheet not updating TODO
this->Internals->Options.render.show_edges = !this->Internals->Options.render.show_edges.value();
}
else
Expand Down
4 changes: 2 additions & 2 deletions testing/baselines/TestInteractionCheatsheet.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions testing/baselines/TestInteractionCheatsheetBlackBG.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions testing/baselines/TestInteractionCheatsheetScalars.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions testing/baselines/TestInteractionCheatsheetWhiteBG.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 0 additions & 2 deletions vtkext/private/module/vtkF3DRenderer.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -1417,8 +1417,6 @@ void vtkF3DRenderer::ConfigureCheatSheet()
cheatSheetText << "\n 1: Front View camera\n";
cheatSheetText << " 3: Right View camera\n";
cheatSheetText << " 4: Roll the camera left by 90 degrees\n";

vtkCamera* camera = GetActiveCamera();
cheatSheetText << " 5: Toggle Orthographic Projection "
<< (this->UseOrthographicProjection.has_value() ? (this->UseOrthographicProjection.value() ? "[ON]" : "[OFF]") : "[unset]") << "\n";
cheatSheetText << " 6: Roll the camera right by 90 degrees\n";
Expand Down

0 comments on commit 31421d7

Please sign in to comment.