Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a --command-script CLI option #1694

Closed
mwestphal opened this issue Nov 7, 2024 · 9 comments
Closed

Add a --command-script CLI option #1694

mwestphal opened this issue Nov 7, 2024 · 9 comments
Assignees
Milestone

Comments

@mwestphal
Copy link
Contributor

Is your feature request related to a problem? Please describe.
libf3d has a command API to to trigger behavior based on a string, lets add a CLI option to provide a script containing commands in a file.

Describe the solution you'd like

  • Add a CLI option in F3DOptionsTools: --command-script
  • in F3DStarter.cxx, process the provided file and use interactor::triggerCommand to trigger the commands
  • Add testing and documentation
@amannages
Copy link
Contributor

Good afternoon, I wanted to ask if this issue was still open? If so, is it possible I could be assigned to issue to work on it?

@mwestphal
Copy link
Contributor Author

Yes, it is open! I've just assigned it to you.

@mwestphal
Copy link
Contributor Author

Do not hesitate to join our discourse for guidance: https://discord.f3d.app

@mwestphal
Copy link
Contributor Author

Hi @amannages

Do you need any help moving forward ?

@amannages
Copy link
Contributor

Hello @mwestphal

Thank you for reaching out, for now since I am just beginning to work on this issue, I do not yet require any help to move forward, but I'll be sure to reach out through the discord if/when I need help.

@mwestphal
Copy link
Contributor Author

Great! Do not hesitate :)

@mwestphal
Copy link
Contributor Author

Hi @amannages

Do you need any help moving forward ?

mwestphal pushed a commit that referenced this issue Dec 2, 2024
Addressing Issue #1694, added --command-script CLI option. 

Includes adding a CLI option in F3DOptionsTools.cxx called ``` --command-script ```

Added the CLI option in F3DOptionsTools.h

In F3DStarter.cxx, implemented relevant code to process the provided file and utilized ``` interactor::triggerCommand ``` to trigger the commands.

Added relevant comments/documentation along with a commandScript test.
@Meakk
Copy link
Member

Meakk commented Dec 16, 2024

@mwestphal this is fixed right?

@mwestphal
Copy link
Contributor Author

indeed!

@github-project-automation github-project-automation bot moved this from To do to Done in F3D Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants