Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC - Behat] Add EzBehatExtension and ArgumentResolver #1586

Merged
merged 2 commits into from
Mar 21, 2016

Conversation

miguelcleverti
Copy link

As decided BehatBundle is to be deprecated and separated between the kernel and platformUI bundle. The idea is to make the Behat easier to maintain, having less repo dependencies should help releases and versions also.

This PR moves the EzBehatExtension and AnnotationArgumentResolver into the kernel. This is used to inject into behat the necessary services. Since this is to be used by most contexts it should be in the kernel.

Related PRs:

@miguelcleverti
Copy link
Author

ping @bdunogier @andrerom @joaoinacio

@bdunogier
Copy link
Member

+1 about the code itself (it has been reviewed before).

But could you please describe the feature a bit better in the PR ? Not everybody has been involved in this. We should also consider documenting it somewhere, in the same PR. Could you take care of it ?

But please before merging, make sure you bump branch-alias in composer.json to 6.3.x-dev if it hasn't been done at that time.

Ping @joaoinacio and @andrerom.

@miguelcleverti
Copy link
Author

@bdunogier I added the BehatExtension/ArgumentResolver docs to the PR and also bumped the branch-alias version. I will include the rest of the docs in their respective PR.

@andrerom
Copy link
Contributor

+1

@miguelcleverti
Copy link
Author

ping @bdunogier @andrerom
two +1's can this be merged?

andrerom added a commit that referenced this pull request Mar 21, 2016
[POC - Behat] Add EzBehatExtension and ArgumentResolver
@andrerom andrerom merged commit 533974f into ezsystems:master Mar 21, 2016
@andrerom
Copy link
Contributor

two +1's can this be merged?

done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants