-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added EzBehatExtension declaration to behat.yml.dist #90
Added EzBehatExtension declaration to behat.yml.dist #90
Conversation
Why are the builds failing ? |
@bdunogier most likely travis is fetching a tag of behat that has not the EzBehatExtension yet! |
Well, I'd rather see the tests pass before we merge :-) Since the file that is missing exists in behatbundle@master, it means the build isn't using the right version of behatbundle. It turns out your base is outdated. You should pull the latest master and rebase (list of changes on master since your branch's base). It fetches behatbundle v6.1.0, while it needs the current master. |
96f52c5
to
3fefa8e
Compare
@bdunogier had my remotes in git with wrong names. Pulled and rebased! |
but still the same error! |
well, as was hinted above travis pulls in the wrong version of behat bundle. side effect of rapid releases with no script yet to make sure everything gets right on first try. So you'll need to fix composer.json. May I suggest you propose to change all ez packages from using example: - "ezsystems/behatbundle": "~6.1.0@dev"
+ "ezsystems/behatbundle": "^6.1.0@dev" This will mean it will always pick latests 6.x dev package instead being locked to a minor branch, I think this is a better match for master, but it will have to be up to @bdunogier to give the verdict on that. |
We were using ^x.y before the 15.12.1 release, but realized that it would automatically upgrade existing enterprise users to the FTR, and it was changed to ~x.y.z to be on the safe side. But we can change it, at least for behatbundle. In any case, the requirements needs to be changed here, since we are using a feature (from ezsystems/behatbundle) that only exists from 6.2.0. Miguel, can you add a commit to the PR that changes the behatbundle requirement from While at it, could you also fix "decalration" in your commit message and PR title ? :-) |
3fefa8e
to
9f1e28d
Compare
Ping ? Needs to be rebased and revived. |
Maybe we should close this one for now because if the the BehatExtension is moved into the kernel has proposed in the POC PR(ezsystems/ezpublish-kernel/pull/1586) then this will be outdated |
well you can also remove change to composer.json and rebase, and theoretically this should then pass given it is part of last behatbundle tag afaik. |
Outdated and no longer applies, closing. |
This is needed for the loading of the needed services in the behat Contexts. PR ezsystems/BehatBundle#47 is dependent of this.