[POC - Behat] Add RepositoryContext trait

[miguelcleverti]

As decided BehatBundle is to be deprecated and separated between the kernel and platformUI bundle. The idea is to make the Behat easier to maintain, having less repo dependencies should help releases and versions also.

This PR moves the RepositoryContext trait into the kernel. This is trait contains all the methods related to the repo . Since this is to be used by any contexts that need the repo it should be in the kernel to be easily included and not duplicate.

Related PRs:

• Behat browser context [POC - Behat] Behat browser context #1585
• Add EzBehatExtension and ArgumentResolver [POC - Behat] Add EzBehatExtension and ArgumentResolver #1586
• Deprecate Behat classes Deprecate Behat classes that will be moved to kernel BehatBundle#48

[miguelcleverti]

ping @bdunogier @andrerom @joaoinacio

[bdunogier]

Please use the full namespace in phpdoc (same below).

[miguelcleverti]

@bdunogier Improved the docs in the Context and added a more detailed to a dedicated behat docs file.

[bdunogier]

How is the repository injected in the trait again ?

[miguelcleverti]

@bdunogier the repository has to be injected into the context in which this trait is used, using the ArgumentResolver (#1586), pass it through the behat.yml into the constructor or any other way...

[bdunogier]

This should be protected, not public. Each context that uses the trait would expose setRepository & loginAdmin, while it is not necessary.

[bdunogier]

I'm not sure what to say. It is fine, and it works, but for many little reasons it does not sound right...

But let's say that if you:

• fix the visibility
• add a getter for $repository and make the property private

I'll be +1 then.

[miguelcleverti]

@dpobel changed the visibility and added the getter

[miguelcleverti]

Actually the loginAdmin() must be public or else behat can't use it for the BeforeScenario Hook

[miguelcleverti]

ping @bdunogier

[bdunogier]

And it is merged. Let's see during the 16.06 cycle how it behaves. I'll use it in a scenario of mine right away.