Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] Fill in min expo-updates version for expo-updates CLI #2344

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

wschurman
Copy link
Member

@wschurman wschurman commented Apr 24, 2024

Why

Same as expo/eas-build#385 but for eas-cli.

Closes ENG-12103.

How

Hardcode

Test Plan

Inspect.

Copy link

github-actions bot commented Apr 24, 2024

Size Change: +28 B (0%)

Total Size: 51.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.4 MB +28 B (0%)

compressed-size-action

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 53.68%. Comparing base (ba4c4e5) to head (6743aba).

❗ Current head 6743aba differs from pull request most recent head 3d1c5c4. Consider uploading reports for the commit 3d1c5c4 to get more accurate results

Files Patch % Lines
packages/eas-cli/src/project/projectUtils.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2344   +/-   ##
=======================================
  Coverage   53.68%   53.68%           
=======================================
  Files         525      525           
  Lines       19274    19274           
  Branches     4068     4068           
=======================================
  Hits        10346    10346           
  Misses       8203     8203           
  Partials      725      725           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wschurman
Copy link
Member Author

/changelog-entry chore Fill in min expo-updates version for expo-updates CLI

Copy link

✅ Thank you for adding the changelog entry!

@wschurman wschurman merged commit b3fca97 into main Apr 25, 2024
5 checks passed
@wschurman wschurman deleted the @wschurman/set-version branch April 25, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants