Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[eas-cli] Fill in min expo-updates version for expo-updates CLI #2344

Merged
merged 2 commits into from
Apr 25, 2024
Merged

[eas-cli] Fill in min expo-updates version for expo-updates CLI #2344

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6743aba
[eas-cli] Fill in min expo-updates version for expo-updates CLI
wschurman Apr 24, 2024
3d1c5c4
update CHANGELOG.md
wschurman Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/eas-cli/src/project/projectUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,8 +165,8 @@ export async function isModernExpoUpdatesCLIWithRuntimeVersionCommandSupportedAs
return true;
}

// TODO(wschurman): add semver check once we know the SDK51 version of expo-updates that supports this
return false;
// Anything SDK 51 or greater uses the expo-updates CLI
return semver.gte(expoUpdatesPackageVersion, '0.25.4');
}

export async function installExpoUpdatesAsync(
Expand Down
Loading