Skip to content

Commit

Permalink
[eas-cli] Fill in min expo-updates version for expo-updates CLI (#2344)
Browse files Browse the repository at this point in the history
  • Loading branch information
wschurman authored Apr 25, 2024
1 parent ba4c4e5 commit b3fca97
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ This is the log of notable changes to EAS CLI and related packages.

### 🧹 Chores

- Fill in min expo-updates version for expo-updates CLI. ([#2344](https://github.com/expo/eas-cli/pull/2344) by [@wschurman](https://github.com/wschurman))

## [7.8.4](https://github.com/expo/eas-cli/releases/tag/v7.8.4) - 2024-04-24

### 🧹 Chores
Expand Down
4 changes: 2 additions & 2 deletions packages/eas-cli/src/project/projectUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -165,8 +165,8 @@ export async function isModernExpoUpdatesCLIWithRuntimeVersionCommandSupportedAs
return true;
}

// TODO(wschurman): add semver check once we know the SDK51 version of expo-updates that supports this
return false;
// Anything SDK 51 or greater uses the expo-updates CLI
return semver.gte(expoUpdatesPackageVersion, '0.25.4');
}

export async function installExpoUpdatesAsync(
Expand Down

0 comments on commit b3fca97

Please sign in to comment.