-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement black-jack
concept exercise
#2592
Implement black-jack
concept exercise
#2592
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactored the code to not use lists
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some suggestions and comments. Since this is a draft, I am going to leave them optional and open for discussion. Thank you for submitting this! 🌟
@pranasziaukas -- in relation to this, would you also like to pick up PR2456, which is the concept write-up for this exercise? |
Thank you for reviewing @BethanyG. Since I'm not a native English speaker I gladly accepted the suggested phrasing changes.
I might pick that one up a bit later. In any case
|
It doesn't have to be. It depends on how you want to work. If it feels better to do it in a follow-on PR, that's completely fine. If you do decide to include that work in this PR, I would then make this a
Only if you want to include the concept write-up. If not, we can change this to full PR and get it reviewed and merged. The exercise won't go "live" on the site however until the concept Just let me know how you want to proceed. 😄 |
Great! I guess I prefer working in smaller chunks. Therefore, I'm marking this PR as ready for review as it is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pranasziaukas - Thank you for this work! 🌟 I think that this PR picked up your follow-on test changes. So merging that one might get weird. Here is me crossing my fingers that it doesn't.
aaand we have conflicts. SAD FACE. @pranasziaukas -- can you try fetching from head and rebasing this locally? If all else fails, we'll have to force it, but I am hoping you can resolve this without that. Thanks! 😄 |
Co-authored-by: BethanyG <[email protected]>
3b1ee78
to
1daf2a9
Compare
Should be good now. The conflict was |
It was me. 😞 I changed the name to Thank you again for resolving things and for working on this! |
Partially addresses #2428
Implemented
as seemed appropriate.
Relied on https://bicyclecards.com/how-to-play/blackjack for some typical house rules.
Overall, seems in-line with teaching python operators.